Potential issue with timer IRQ handlers

[dresco]

Have noticed something while troubleshooting my stepper spindle issues (was just an incorrect timer IRQ handler name - difference with the H7 part).

However, some of the handlers have two timer sources, and the existing code doesn't seem to handle this correctly? An example for the F7 would be TIM1_UP_TIM10_IRQHandler. This currently assumes the signal has come from TIM1, and then the TIM10 equivalent references TIM10_IRQHandler which doesn't exist.

I think the handler needs to check the SR register for all potential sources, and call _irq_handler() accordingly. However, am not clear how this would affect the existing LAST_TIDX logic?

[terjeio]

It can be solved by moving the TIMx_TIDX enums to the start of the file?

[dresco]

Makes sense I think..

So would be one pass through the #ifdef's to define the enums, and then another pass through to add the interrupt handlers? (Btw, I notice only some check for being claimed)?

And for the interrupts with multiple sources, seems it would be safe to call both, as _irq_handler() already checks the SR flags. Something like this (for an H7 example)?

#if defined(TIM8) || defined(TIM13)

ISR_CODE void TIM8_UP_TIM13_IRQHandler (void)
{
    _irq_handler(TIM8, &timers[TIM8_IDX].cfg);
    _irq_handler(TIM13, &timers[TIM13_IDX].cfg);
}

#endif

[dresco]

Hmm, I guess would also need to guard within the function, in case only one of the two timers is defined..