Skip to content

Commit 4e2f4cb

Browse files
s_roes_roe
authored andcommitted
use Path.Combine for portable path
1 parent bbd33df commit 4e2f4cb

File tree

5 files changed

+15
-3
lines changed

5 files changed

+15
-3
lines changed

src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/Extensions/LoggerExtensions.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88

99
namespace Gravity.Abstraction.Logging.Extensions
1010
{
11+
/// <summary>
12+
/// Extensions package for ILogger.
13+
/// </summary>
1114
public static class LoggerExtensions
1215
{
1316
/// <summary>

src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/ILogger.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55

66
namespace Gravity.Abstraction.Logging
77
{
8+
/// <summary>
9+
/// ILogger interface.
10+
/// </summary>
811
public interface ILogger
912
{
1013
/// <summary>

src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/LogFactory.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55

66
namespace Gravity.Abstraction.Logging
77
{
8+
/// <summary>
9+
/// Factory for creating loggers based on ILogger.
10+
/// </summary>
811
public static class LogFactory
912
{
1013
/// <summary>

src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/Logger.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99

1010
namespace Gravity.Abstraction.Logging
1111
{
12+
/// <summary>
13+
/// Base class for all ILogger implementations.
14+
/// </summary>
1215
public abstract class Logger : ILogger
1316
{
1417
// members: state

src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/TraceLogger.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,12 @@ public override void OnExecutor(string level, IDictionary<string, object> logMes
9393
private void SetupTraceListener(string instanceName, string inDirectory)
9494
{
9595
// setup directory
96-
var directory = string.IsNullOrEmpty(inDirectory)
96+
var directory = string.IsNullOrEmpty(inDirectory) || inDirectory.Equals(".")
9797
? Environment.CurrentDirectory
9898
: inDirectory;
9999

100100
// initialize listener
101-
Directory.CreateDirectory(directory.Replace("\\\\", "\\").Replace("//", "/"));
101+
Directory.CreateDirectory(directory);
102102

103103
// setup conditions
104104
var exists = System.Diagnostics.Trace
@@ -111,7 +111,7 @@ private void SetupTraceListener(string instanceName, string inDirectory)
111111
}
112112

113113
// setup trace
114-
var fileName = $"{directory}\\{instanceName}-{DateTime.Now:yyyyMMdd}.log";
114+
var fileName = Path.Combine(directory, $"{instanceName}-{DateTime.Now:yyyyMMdd}.log");
115115
System.Diagnostics.Trace.AutoFlush = true;
116116
System.Diagnostics.Trace.Listeners.Add(new TextWriterTraceListener(fileName, name: instanceName));
117117
}

0 commit comments

Comments
 (0)