refactor: update kubectl error and warnings

Author: kamiiiel

api/v1alpha1/apiv4definition_webhook.go

@@ -58,7 +58,7 @@ func validateApi(api *ApiV4Definition) (admission.Warnings, error) {
 	if api.HasContext() {
 		mCtx := new(ManagementContext)
 		if err := k8s.GetClient().Get(context.Background(), api.ContextRef().NamespacedName(), mCtx); err != nil {
-			return admission.Warnings{}, fmt.Errorf("can't create api [%s] because it is using "+
+			return admission.Warnings{}, fmt.Errorf("can't create API [%s] because it is using "+
 				"management context [%v] that doesn't exist in the cluster", api.Name, api.ContextRef().NamespacedName())
 		}
 	} else {
@@ -132,7 +132,7 @@ func findDuplicatePath(existingPaths []string, newPaths []string) error {
 	for _, ep := range existingPaths {
 		for _, np := range newPaths {
 			if ep == np {
-				return fmt.Errorf("invalid api context path. the same path already exist [%s]", ep)
+				return fmt.Errorf("invalid API context path [%s]. Another API with the same path already exists", ep)
 			}
 		}
 	}

api/v1alpha1/managementcontext_webhook.go

@@ -62,8 +62,8 @@ func validateManagementContext(ctx *ManagementContext) (admission.Warnings, erro
 		secret := new(corev1.Secret)
 		err := k8s.GetClient().Get(context.Background(), ctx.Spec.SecretRef().NamespacedName(), secret)
 		if err != nil {
-			return admission.Warnings{}, errors.Wrap(err, fmt.Sprintf("can't create management context because it is using "+
-				"sercret [%v] that doesn't exist in the cluster", ctx.Spec.SecretRef()))
+			return admission.Warnings{}, fmt.Errorf("can't create management context [%s] because it is using "+
+				"sercret [%v] that doesn't exist in the cluster", ctx.Name, ctx.Spec.SecretRef())
 		}
 	}
 
@@ -88,7 +88,7 @@ func checkAPIAvailability(ctx *ManagementContext) error {
 
 	var opError *net.OpError
 	if errors.As(err, &opError) {
-		return err
+		return fmt.Errorf("unable to reach APIM, [%s] is not available", ctx.Spec.BaseUrl)
 	}
 
 	return nil