test: lower constistent timeouts to speed up pipelines

Author: a-cordier

test/integration/admission/managementcontext_create_withBadCredentials_test.go

@@ -56,6 +56,6 @@ var _ = Describe("Validate create", labels.WithContext, func() {
 				),
 				err,
 			)
-		}, constants.EventualTimeout, interval).Should(Succeed())
+		}, constants.ConsistentTimeout, interval).Should(Succeed())
 	})
 })

test/integration/admission/managementcontext_create_withEnvironmentNotFound_test.go

@@ -49,6 +49,6 @@ var _ = Describe("Validate create", labels.WithContext, func() {
 		Consistently(func() error {
 			_, err := admissionCtrl.ValidateCreate(ctx, fixtures.Context)
 			return assert.NotNil("error", err)
-		}, constants.EventualTimeout, interval).Should(Succeed())
+		}, constants.ConsistentTimeout, interval).Should(Succeed())
 	})
 })

test/integration/admission/managementcontext_create_withMissingSecret_test.go

@@ -29,7 +29,6 @@ import (
 )
 
 var _ = Describe("Validate create", labels.WithContext, func() {
-	timeout := constants.EventualTimeout / 10
 	interval := constants.Interval
 	ctx := context.Background()
 	admissionCtrl := mctx.AdmissionCtrl{}
@@ -42,6 +41,6 @@ var _ = Describe("Validate create", labels.WithContext, func() {
 		Consistently(func() error {
 			_, err := admissionCtrl.ValidateCreate(ctx, fixtures.Context)
 			return err
-		}, timeout, interval).Should(HaveOccurred())
+		}, constants.ConsistentTimeout, interval).Should(HaveOccurred())
 	})
 })

test/integration/admission/managementcontext_update_withNetworkError_test.go

@@ -34,7 +34,6 @@ import (
 )
 
 var _ = Describe("Validate update", labels.WithContext, func() {
-	timeout := constants.EventualTimeout
 	interval := constants.Interval
 	admissionCtrl := mctx.AdmissionCtrl{}
 	ctx := context.Background()
@@ -66,11 +65,11 @@ var _ = Describe("Validate update", labels.WithContext, func() {
 				Namespace: mCtx.Namespace,
 				Name:      mCtx.Name,
 			}, mCtx)
-		}, timeout, interval).Should(Succeed())
+		}, constants.EventualTimeout, interval).Should(Succeed())
 
 		Consistently(func() error {
 			warnings, _ := admissionCtrl.ValidateUpdate(ctx, mCtx, mCtx)
 			return assert.SliceOfSize("warnings", warnings, 1)
-		}, timeout, interval).ShouldNot(Succeed())
+		}, constants.ConsistentTimeout, interval).ShouldNot(Succeed())
 	})
 })

test/internal/integration/constants/constants.go

@@ -25,7 +25,7 @@ import (
 const (
 	Namespace = "default"
 
-	ConsistentTimeout = time.Second * 3
+	ConsistentTimeout = time.Second * 2
 	EventualTimeout   = time.Second * 30
 	Interval          = time.Millisecond * 250