Skip to content

Commit 9e3d7ac

Browse files
authored
Add Benjie and many agenda items to Dec WG (#1435)
1 parent 4cc7749 commit 9e3d7ac

File tree

2 files changed

+54
-25
lines changed

2 files changed

+54
-25
lines changed

agendas/2023/11-Nov/16-wg-secondary-eu.md

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -124,21 +124,5 @@ who could not make the primary meeting time.
124124
- [Ready for review](https://github.com/graphql/graphql-wg/issues?q=is%3Aissue+is%3Aopen+label%3A%22Ready+for+review+%F0%9F%99%8C%22+sort%3Aupdated-desc)
125125
- [All open action items (by last update)](https://github.com/graphql/graphql-wg/issues?q=is%3Aissue+is%3Aopen+label%3A%22Action+item+%3Aclapper%3A%22+sort%3Aupdated-desc)
126126
- [All open action items (by meeting)](https://github.com/graphql/graphql-wg/projects?query=is%3Aopen+sort%3Aname-asc)
127-
1. Fix bug in coercion table for lists (5m, Benjie)
128-
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1057)
129-
- No GraphQL.js PR needed, GraphQL.js already implements the correct behavior
130-
1. Forbid deprecating object field if interface field isn't deprecated (10m, Benjie)
131-
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1053)
132-
- [GraphQL.js PR](https://github.com/graphql/graphql-js/pull/3986)
133-
1. Fix bug in CoerceArgumentValues() algorithm (10m, Benjie)
134-
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1056)
135-
- No GraphQL.js PR needed, GraphQL.js already implements the correct behavior
136-
1. Define "selection set" and clarify serial selection set execution (10m, Benjie)
137-
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1032)
138-
1. Detail variables in list input coercion rules (30m, Benjie)
139-
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1058)
140-
- Previously discussed (but incorrectly interpreted) in December 2022: https://github.com/graphql/graphql-wg/blob/main/notes/2022/2022-12.md?rgh-link-date=2023-07-08T08%3A09%3A10Z#field-error-resulting-from-insufficient-validation-of-variables-15m-benjie
141-
1. Introduce Strict and Legacy All Variable Usages Are Allowed validation rules (20m, Benjie)
142-
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1059)
143-
- Aim: before I go about implementing this in GraphQL.js, are we agreed this is the right solution?
144-
- Question: should we enable the new algorithm by default in the next major bump of GraphQL.js, and enable users to opt-in to the old version if they need to?
127+
128+
Meeting cancelled due to lack of attendance.

agendas/2023/12-Dec/07-wg-primary.md

Lines changed: 52 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,11 @@ hold additional secondary meetings later in the month.
9999

100100
## Attendees
101101

102+
<!-- prettier-ignore -->
102103
| Name | GitHub | Organization | Location |
103104
| :--------------- | :------------ | :----------------- | :-------------------- |
104105
| Lee Byron (Host) | @leebyron | GraphQL Foundation | San Francisco, CA, US |
105-
106+
| Benjie Gillam | @benjie | Graphile | Chandler's Ford, UK |
106107

107108
## Agenda
108109

@@ -114,10 +115,54 @@ hold additional secondary meetings later in the month.
114115
1. Introduction of attendees (5m, Lee)
115116
1. Determine volunteers for note taking (1m, Lee)
116117
1. Review agenda (2m, Lee)
117-
1. Review prior secondary meetings (5m, Lee)
118-
- [November WG Secondary, APAC](https://github.com/graphql/graphql-wg/blob/main/agendas/2023/11-Nov/08-wg-secondary-apac.md)
119-
- [November WG Secondary, EU](https://github.com/graphql/graphql-wg/blob/main/agendas/2023/11-Nov/16-wg-secondary-eu.md)
120-
1. Review previous meeting's action items (5m, Lee)
121-
- [Ready for review](https://github.com/graphql/graphql-wg/issues?q=is%3Aissue+is%3Aopen+label%3A%22Ready+for+review+%F0%9F%99%8C%22+sort%3Aupdated-desc)
118+
1. ~~Review prior secondary meetings (5m, Lee)~~
119+
- ~~[November WG Secondary, APAC](https://github.com/graphql/graphql-wg/blob/main/agendas/2023/11-Nov/08-wg-secondary-apac.md)~~
120+
- ~~[November WG Secondary, EU](https://github.com/graphql/graphql-wg/blob/main/agendas/2023/11-Nov/16-wg-secondary-eu.md)~~
121+
1. Review previous meeting's action items (30m, Benjie)
122+
- https://github.com/graphql/graphql-wg/issues/1345 - everyone review default
123+
value validation
124+
- Sufficient review time has elapsed
125+
- https://github.com/graphql/graphql-wg/issues/695 - no `@skip`/`@include` on
126+
subscriptions - raise GraphQL.js PR
127+
- [GraphQL.js PR](https://github.com/graphql/graphql-js/pull/3974) raised
128+
- https://github.com/graphql/graphql-wg/issues/1331 - if interface field
129+
deprecated, then object field should be deprecated
130+
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1053) and
131+
[GraphQL.js PR](https://github.com/graphql/graphql-js/pull/3986) raised
132+
- https://github.com/graphql/graphql-wg/issues/1336 - coercing variable
133+
values in lists; clarify spec text
134+
- Discussed December 2022, but the issue was misinterpretted; it relates to
135+
variables inside _lists_, not in arguments directly
136+
- Spec editorial PR:
137+
[fix bug in list coercion example table](https://github.com/graphql/graphql-spec/pull/1057/files)
138+
- Agenda item below: "Detail variables in list input coercion rules"
139+
- https://github.com/graphql/graphql-wg/issues/1414 - example of executing
140+
_selection set_ serially, readers expect an operation; clarify
141+
- Spec PR:
142+
[define "selection set" and clarify examples in section 6](https://github.com/graphql/graphql-spec/pull/1032)
143+
- https://github.com/graphql/graphql-wg/issues/1337 - forbid nullable
144+
variable with default in non-nullable position
145+
- Agenda item below: "Introduce Strict and Legacy All Variable Usages Are
146+
Allowed validation rules"
147+
- https://github.com/graphql/graphql-wg/issues/1413 - close all aging action
148+
items
149+
- [Stale closed items](https://github.com/graphql/graphql-wg/issues?q=is%3Aissue+is%3Aclosed+sort%3Aupdated-desc+label%3Astale+)
150+
- Note: not all items closed were "action items"
122151
- [All open action items (by last update)](https://github.com/graphql/graphql-wg/issues?q=is%3Aissue+is%3Aopen+label%3A%22Action+item+%3Aclapper%3A%22+sort%3Aupdated-desc)
123-
- [All open action items (by meeting)](https://github.com/graphql/graphql-wg/projects?query=is%3Aopen+sort%3Aname-asc)
152+
- [All open action items (by meeting)](https://github.com/graphql/graphql-wg/projects?type=classic&query=is%3Aopen+sort%3Aupdated-desc)
153+
1. Fix bug in CoerceArgumentValues() algorithm (10m, Benjie)
154+
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1056)
155+
- No GraphQL.js PR needed, GraphQL.js already implements the correct behavior
156+
1. Detail variables in list input coercion rules (15m, Benjie)
157+
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1058)
158+
- GraphQL.js already implements the correct behavior?
159+
- Previously discussed (but incorrectly interpreted) in December 2022:
160+
https://github.com/graphql/graphql-wg/blob/main/notes/2022/2022-12.md?rgh-link-date=2023-07-08T08%3A09%3A10Z#field-error-resulting-from-insufficient-validation-of-variables-15m-benjie
161+
1. Introduce Strict and Legacy All Variable Usages Are Allowed validation rules
162+
(15m, Benjie)
163+
- [Spec PR](https://github.com/graphql/graphql-spec/pull/1059)
164+
- Aim: before I go about implementing this in GraphQL.js, are we agreed this
165+
is the right solution?
166+
- Question: should we enable the new algorithm by default in the next major
167+
bump of GraphQL.js, and enable users to opt-in to the old version if they
168+
need to?

0 commit comments

Comments
 (0)