Skip to content

Commit 3b8a74b

Browse files
authored
Update criterion match in input union RFC (#784)
* Update criterion match in input union RFC * Update Evaluation Overview
1 parent d3ea511 commit 3b8a74b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

rfcs/InputUnion.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ input union IU = I | { y: Int }
305305

306306
| [1][solution-1] | [2][solution-2] | [3][solution-3] | [4][solution-4] | [5][solution-5] |
307307
|----|----|----|----|----|
308-
| ✅⚠️ | ✅⚠️ || ⚠️ | |
308+
| ✅⚠️ | ✅⚠️ || ⚠️ | 🚫 |
309309

310310
Criteria score: 🥉
311311

@@ -864,7 +864,7 @@ type Mutation {
864864
* [E. A member type may be a Leaf type][criteria-e]
865865
* ✅ Any GraphQL type may be used
866866
* [F. Migrating a field to a polymorphic input type is non-breaking][criteria-f]
867-
* ✅ No migration required, as this pattern is already possible
867+
* 🚫 Previously-valid inputs now need to be wrapped in a container object
868868
* [H. Input unions should accept plain data][criteria-h]
869869
* ⚠️ The data is wrapped in a (simple) container type
870870
* [I. Input unions should be easy to upgrade from existing solutions][criteria-i]
@@ -902,7 +902,7 @@ A quick glance at the evaluation results. Remember that passing or failing a spe
902902
| [C][criteria-c] 🥇 | ✅ | ✅⚠️ | 🚫 | ⚠️ | ✅ |
903903
| [D][criteria-d] 🥇 | ✅ | ✅ | ✅ | ✅ | ✅ |
904904
| [E][criteria-e] 🥉 | 🚫 | 🚫 | ✅⚠️ | 🚫 | ✅ |
905-
| [F][criteria-f] 🥉 | ✅⚠️ | ✅⚠️ | ✅ | ⚠️ | |
905+
| [F][criteria-f] 🥉 | ✅⚠️ | ✅⚠️ | ✅ | ⚠️ | 🚫 |
906906
| [G][criteria-g] 🥉 | ❔ | ❔ | ❔ | ❔ | ❔ |
907907
| [H][criteria-h] 🥉 | ⚠️ | ⚠️ | ✅ | ✅ | ⚠️ |
908908
| [I][criteria-i] 🥉 | ✅ | ✅ | ✅ | ⚠️ | ✅ |

0 commit comments

Comments
 (0)