change @typescript-eslint/return-await to 'always'

Motivation:  It is faster to await a promise prior to returning it from an async function than to return a promise with `.then()`.

See: https://github.com/tc39/proposal-faster-promise-adoption

Previously, this eslint rule errored by default only 'in-try-catch'.

Author: yaacovCR

.eslintrc.yml

@@ -651,7 +651,7 @@ overrides:
         ]
       '@typescript-eslint/no-useless-constructor': error
       '@typescript-eslint/require-await': error
-      '@typescript-eslint/return-await': error
+      '@typescript-eslint/return-await': [error, 'always']
 
       # Disable for JS and TS
       '@typescript-eslint/init-declarations': off

resources/gen-changelog.ts

@@ -294,7 +294,7 @@ async function getPRsInfo(
   let prNumbers = await splitBatches(commits, batchCommitToPR);
   prNumbers = Array.from(new Set(prNumbers)); // Remove duplicates
 
-  return splitBatches(prNumbers, batchPRInfo);
+  return await splitBatches(prNumbers, batchPRInfo);
 }
 
 // Split commits into batches of 50 to prevent timeouts

src/execution/__tests__/simplePubSub-test.ts

@@ -23,7 +23,7 @@ describe('SimplePubSub', () => {
     });
 
     async function getNextItem(i: AsyncIterator<unknown>) {
-      return i.next();
+      return await i.next();
     }
 
     // Read ahead

src/execution/__tests__/stream-test.ts

@@ -126,7 +126,7 @@ async function completeAsync(
   for (let i = 0; i < numCalls; i++) {
     promises.push(iterator.next());
   }
-  return Promise.all(promises);
+  return await Promise.all(promises);
 }
 
 function createResolvablePromise<T>(): [Promise<T>, (value?: T) => void] {
@@ -531,11 +531,6 @@ describe('Execute: stream directive', () => {
               },
             ],
           },
-        ],
-        hasNext: true,
-      },
-      {
-        incremental: [
           {
             items: [{ name: 'Leia', id: '3' }],
             path: ['friendList', 2],

src/execution/execute.ts

@@ -1077,7 +1077,9 @@ async function completeAsyncIteratorValue(
     }
     index += 1;
   }
-  return containsPromise ? Promise.all(completedResults) : completedResults;
+  return containsPromise
+    ? await Promise.all(completedResults)
+    : completedResults;
 }
 
 /**
@@ -2222,7 +2224,7 @@ function yieldSubsequentPayloads(
     const hasNext = exeContext.subsequentPayloads.size > 0;
 
     if (!incremental.length && hasNext) {
-      return next();
+      return await next();
     }
 
     if (!hasNext) {
@@ -2265,7 +2267,7 @@ function yieldSubsequentPayloads(
     ): Promise<IteratorResult<SubsequentIncrementalExecutionResult, void>> {
       await returnStreamIterators();
       isDone = true;
-      return Promise.reject(error);
+      return await Promise.reject(error);
     },
   };
 }

src/execution/mapAsyncIterable.ts

@@ -36,17 +36,17 @@ export function mapAsyncIterable<T, U, R = undefined>(
 
   return {
     async next() {
-      return mapResult(await iterator.next());
+      return await mapResult(await iterator.next());
     },
     async return(): Promise<IteratorResult<U, R>> {
       // If iterator.return() does not exist, then type R must be undefined.
       return typeof iterator.return === 'function'
-        ? mapResult(await iterator.return())
+        ? await mapResult(await iterator.return())
         : { value: undefined as any, done: true };
     },
     async throw(error?: unknown) {
       if (typeof iterator.throw === 'function') {
-        return mapResult(await iterator.throw(error));
+        return await mapResult(await iterator.throw(error));
       }
       throw error;
     },

src/jsutils/after.ts

@@ -1,8 +1,13 @@
-import type { PromiseOrValue } from './PromiseOrValue';
+import { isPromise } from './isPromise.js';
+import type { PromiseOrValue } from './PromiseOrValue.js';
 
 export async function after<T, R>(
   promise: Promise<T>,
   onFulfilled: (value: T) => PromiseOrValue<R>,
 ): Promise<R> {
-  return onFulfilled(await promise);
+  const result = onFulfilled(await promise);
+  if (isPromise(result)) {
+    return await result;
+  }
+  return result;
 }