internal: fix inlineInvariant for cjs builds that require filenames with explicit extensions (#3832)

Author: yaacovCR

integrationTests/node/index.cjs

@@ -1,7 +1,11 @@
 const assert = require('assert');
 const { readFileSync } = require('fs');
 
-const { graphqlSync } = require('graphql');
+const {
+  experimentalExecuteIncrementally,
+  graphqlSync,
+  parse,
+} = require('graphql');
 const { buildSchema } = require('graphql/utilities');
 const { version } = require('graphql/version');
 
@@ -12,7 +16,7 @@ assert.deepStrictEqual(
 
 const schema = buildSchema('type Query { hello: String }');
 
-const result = graphqlSync({
+let result = graphqlSync({
   schema,
   source: '{ hello }',
   rootValue: { hello: 'world' },
@@ -24,3 +28,27 @@ assert.deepStrictEqual(result, {
     hello: 'world',
   },
 });
+
+/**
+ * The below test triggers a call `invariant` method during execution (by
+ * passing a negative number to the `initialCount` parameter on the `@stream`
+ * directive). This ensures that the `inlineInvariant` method called by our
+ * build script works correctly.
+ **/
+
+const experimentalSchema = buildSchema(`
+  directive @stream(initialCount: Int!) on FIELD
+
+  type Query {
+    greetings: [String]
+  }
+`);
+
+result = experimentalExecuteIncrementally({
+  schema: experimentalSchema,
+  document: parse('{ greetings @stream(initialCount: -1) }'),
+  rootValue: { greetings: ['hi', 'hello'] },
+});
+
+assert(result.errors?.[0] !== undefined);
+assert(!result.errors[0].message.includes('is not defined'));

integrationTests/node/index.mjs

@@ -2,7 +2,11 @@
 import assert from 'assert';
 import { readFileSync } from 'fs';
 
-import { graphqlSync } from 'graphql-esm';
+import {
+  experimentalExecuteIncrementally,
+  graphqlSync,
+  parse,
+} from 'graphql-esm';
 import { buildSchema } from 'graphql-esm/utilities';
 import { version } from 'graphql-esm/version';
 
@@ -13,7 +17,7 @@ assert.deepStrictEqual(
 
 const schema = buildSchema('type Query { hello: String }');
 
-const result = graphqlSync({
+let result = graphqlSync({
   schema,
   source: '{ hello }',
   rootValue: { hello: 'world' },
@@ -25,3 +29,27 @@ assert.deepStrictEqual(result, {
     hello: 'world',
   },
 });
+
+/**
+ * The below test triggers a call `invariant` method during execution (by
+ * passing a negative number to the `initialCount` parameter on the `@stream`
+ * directive). This ensures that the `inlineInvariant` method called by our
+ * build script works correctly.
+ **/
+
+const experimentalSchema = buildSchema(`
+  directive @stream(initialCount: Int!) on FIELD
+
+  type Query {
+    greetings: [String]
+  }
+`);
+
+result = experimentalExecuteIncrementally({
+  schema: experimentalSchema,
+  document: parse('{ greetings @stream(initialCount: -1) }'),
+  rootValue: { greetings: ['hi', 'hello'] },
+});
+
+assert(result.errors?.[0] !== undefined);
+assert(!result.errors[0].message.includes('is not defined'));

resources/inline-invariant.ts

@@ -32,11 +32,10 @@ export function inlineInvariant(context: ts.TransformationContext) {
           return factory.createBinaryExpression(
             factory.createParenthesizedExpression(condition),
             ts.SyntaxKind.BarBarToken,
-            factory.createCallExpression(
-              factory.createIdentifier(funcName),
-              undefined,
-              [factory.createFalse(), ...otherArgs],
-            ),
+            factory.createCallExpression(expression, undefined, [
+              factory.createFalse(),
+              ...otherArgs,
+            ]),
           );
         }
       }