Configure majority of undecided ESLint rules (#1544)

* Configure majority of undecided ESLint rules

* Address @mjmahone review comment

Author: IvanGoncharov

.eslintrc.yml

@@ -71,12 +71,16 @@ rules:
   flowtype/use-flow-type: error
   flowtype/valid-syntax: off
 
+  ##################################################
+  # ESLint builtin rules list based on `v5.6.0`
+  ##################################################
+
   # Possible Errors
   # https://eslint.org/docs/rules/#possible-errors
 
   for-direction: error
   getter-return: error
-  #no-async-promise-executor: undecided
+  no-async-promise-executor: error
   no-await-in-loop: error
   no-compare-neg-zero: error
   no-cond-assign: error
@@ -97,28 +101,28 @@ rules:
   no-inner-declarations: [error, functions]
   no-invalid-regexp: error
   no-irregular-whitespace: error
-  #no-misleading-character-class: undecided
+  no-misleading-character-class: error
   no-obj-calls: error
   #no-prototype-builtins: undecided
   no-regex-spaces: error
   no-sparse-arrays: error
-  #no-template-curly-in-string: undecided
+  no-template-curly-in-string: error
   no-unexpected-multiline: off
   no-unreachable: error
   no-unsafe-finally: error
   no-unsafe-negation: error
-  #require-atomic-updates: undecided
+  require-atomic-updates: error
   use-isnan: error
   valid-jsdoc: off
   valid-typeof: error
 
   # Best Practices
   # https://eslint.org/docs/rules/#best-practices
 
-  #accessor-pairs: undecided
-  #array-callback-return: undecided
+  accessor-pairs: error
+  array-callback-return: [error, { allowImplicit: true }]
   block-scoped-var: off
-  #class-methods-use-this: undecided
+  class-methods-use-this: off
   complexity: off
   consistent-return: off
   curly: [error, all]
@@ -127,32 +131,32 @@ rules:
   dot-notation: off
   eqeqeq: [error, smart]
   guard-for-in: error
-  #max-classes-per-file: undecided
+  max-classes-per-file: off
   no-alert: error
   no-caller: error
   # TODO: recommended rule but disable due to errors in existing code
   # no-case-declarations: error
   no-div-regex: error
   no-else-return: error
-  #no-empty-function: undecided
+  no-empty-function: off
   no-empty-pattern: error
   no-eq-null: off
   no-eval: error
   no-extend-native: error
   no-extra-bind: error
-  #no-extra-label: undecided
+  no-extra-label: error
   no-fallthrough: error
   no-floating-decimal: off
   no-global-assign: error
   no-implicit-coercion: error
-  #no-implicit-globals: undecided
+  no-implicit-globals: off
   no-implied-eval: error
   no-invalid-this: off
   no-iterator: error
   no-labels: [error, {allowLoop: true}]
   no-lone-blocks: error
   no-loop-func: off
-  #no-magic-numbers: undecided
+  no-magic-numbers: off
   no-multi-spaces: off
   no-multi-str: error
   no-new: error
@@ -163,19 +167,19 @@ rules:
   no-param-reassign: error
   no-proto: error
   no-redeclare: error
-  #no-restricted-properties: undecided
+  no-restricted-properties: off
   no-return-assign: error
-  #no-return-await: undecided
+  no-return-await: error
   no-script-url: error
   no-self-assign: error
   no-self-compare: off
   no-sequences: off
   no-throw-literal: error
-  #no-unmodified-loop-condition: undecided
+  no-unmodified-loop-condition: error
   no-unused-expressions: error
   no-unused-labels: error
   no-useless-call: error
-  #no-useless-concat: undecided
+  no-useless-concat: error
   no-useless-escape: error
   no-useless-return: error
   no-void: error
@@ -184,7 +188,7 @@ rules:
   #prefer-promise-reject-errors: undecided
   radix: error
   #require-await: undecided
-  #require-unicode-regexp: undecided
+  require-unicode-regexp: off
   vars-on-top: off
   wrap-iife: off
   yoda: [error, never, {exceptRange: true}]
@@ -200,7 +204,7 @@ rules:
   init-declarations: off
   no-delete-var: error
   no-label-var: error
-  #no-restricted-globals: undecided
+  no-restricted-globals: off
   no-shadow: error
   no-shadow-restricted-names: error
   no-undef: error
@@ -213,9 +217,9 @@ rules:
   # https://eslint.org/docs/rules/#nodejs-and-commonjs
 
   callback-return: error
-  #global-require: undecided
+  global-require: error
   handle-callback-err: [error, error]
-  #no-buffer-constructor: undecided
+  no-buffer-constructor: error
   no-mixed-requires: [error, true]
   no-new-require: error
   no-path-concat: error
@@ -241,11 +245,11 @@ rules:
   consistent-this: off
   eol-last: off
   func-call-spacing: off
-  #func-name-matching: undecided
+  func-name-matching: off
   func-names: off
   func-style: off
   function-paren-newline: off
-  #id-blacklist: undecided
+  id-blacklist: off
   id-length: off
   id-match: [error, "^(?:_?[a-zA-Z0-9]*)|[_A-Z0-9]+$"]
   implicit-arrow-linebreak: off
@@ -256,15 +260,15 @@ rules:
   #line-comment-position: undecided
   linebreak-style: error
   lines-around-comment: off
-  #lines-between-class-members: undecided
+  lines-between-class-members: off
   max-depth: off
   max-len: off
-  #max-lines: undecided
-  #max-lines-per-function: undecided
+  max-lines: off
+  max-lines-per-function: off
   max-nested-callbacks: off
   max-params: off
   max-statements: off
-  #max-statements-per-line: undecided
+  max-statements-per-line: off
   #multiline-comment-style: undecided
   multiline-ternary: off
   new-cap: off
@@ -277,15 +281,15 @@ rules:
   no-lonely-if: error
   no-mixed-operators: off
   no-mixed-spaces-and-tabs: off
-  #no-multi-assign: undecided
+  no-multi-assign: off
   no-multiple-empty-lines: off
-  #no-negated-condition: undecided
+  no-negated-condition: off
   no-nested-ternary: off
   no-new-object: error
   no-plusplus: off
   no-spaced-func: off
-  #no-restricted-syntax: undecided
-  #no-tabs: undecided
+  no-restricted-syntax: off
+  no-tabs: error
   no-ternary: off
   no-trailing-spaces: off
   no-underscore-dangle: off
@@ -301,14 +305,14 @@ rules:
   operator-linebreak: off
   padded-blocks: off
   padding-line-between-statements: off
-  #prefer-object-spread: undecided
+  prefer-object-spread: error
   quote-props: off
   quotes: off
   #require-jsdoc: undecided
   semi: off
   semi-spacing: off
   semi-style: off
-  #sort-keys: undecided
+  sort-keys: off
   sort-vars: off
   space-before-blocks: off
   space-before-function-paren: off
@@ -324,31 +328,31 @@ rules:
   # ECMAScript 6
   # https://eslint.org/docs/rules/#ecmascript-6
 
-  #arrow-body-style: undecided
+  arrow-body-style: off
   arrow-parens: off
   arrow-spacing: off
   constructor-super: error
   generator-star-spacing: off
   no-class-assign: error
-  #no-confusing-arrow: undecided
+  no-confusing-arrow: off
   no-const-assign: error
   no-dupe-class-members: error
   #no-duplicate-imports: undecided
   no-new-symbol: error
-  #no-restricted-imports: undecided
+  no-restricted-imports: off
   no-this-before-super: error
-  #no-useless-computed-key: undecided
-  #no-useless-constructor: undecided
-  #no-useless-rename: undecided
+  no-useless-computed-key: error
+  no-useless-constructor: error
+  no-useless-rename: error
   no-var: error
   object-shorthand: [error, always]
-  #prefer-arrow-callback: undecided
+  prefer-arrow-callback: error
   prefer-const: error
-  #prefer-destructuring: undecided
-  #prefer-numeric-literals: undecided
+  prefer-destructuring: off
+  prefer-numeric-literals: error
   #prefer-rest-params: undecided
   prefer-spread: off
-  #prefer-template: undecided
+  prefer-template: off
   require-yield: off
   rest-spread-spacing: off
   #sort-imports: undecided

src/execution/__tests__/sync-test.js

@@ -29,7 +29,7 @@ describe('Execute: synchronously when possible', () => {
         asyncField: {
           type: GraphQLString,
           async resolve(rootValue) {
-            return await rootValue;
+            return rootValue;
           },
         },
       },

src/language/__tests__/lexer-test.js

@@ -7,6 +7,8 @@
  * @noflow
  */
 
+import { inspect as utilInspect } from 'util';
+
 import { expect } from 'chai';
 import { describe, it } from 'mocha';
 import dedent from '../../jsutils/dedent';
@@ -62,7 +64,7 @@ describe('Lexer', () => {
     expect(JSON.stringify(token)).to.equal(
       '{"kind":"Name","value":"foo","line":1,"column":1}',
     );
-    expect(require('util').inspect(token)).to.equal(
+    expect(utilInspect(token)).to.equal(
       "{ kind: 'Name', value: 'foo', line: 1, column: 1 }",
     );
   });
@@ -129,7 +131,7 @@ describe('Lexer', () => {
   it('updates line numbers in error for file context', () => {
     let caughtError;
     try {
-      const str = '' + '\n' + '\n' + '     ?\n' + '\n';
+      const str = ['', '', '     ?', ''].join('\n');
       const source = new Source(str, 'foo.js', { line: 11, column: 12 });
       createLexer(source).advance();
     } catch (error) {