isolate async iterator next rejection within try block

to improve readability

Author: yaacovCR

src/execution/execute.ts

@@ -1065,15 +1065,16 @@ async function completeAsyncIteratorValue(
     try {
       // eslint-disable-next-line no-await-in-loop
       iteration = await iterator.next();
-      if (iteration.done) {
-        break;
-      }
     } catch (rawError) {
       const error = locatedError(rawError, fieldNodes, pathToArray(itemPath));
       completedResults.push(handleFieldError(error, itemType, errors));
       break;
     }
 
+    if (iteration.done) {
+      break;
+    }
+
     if (
       completeListItemValue(
         iteration.value,
@@ -2008,30 +2009,34 @@ async function executeStreamAsyncIteratorItem(
   asyncPayloadRecord: StreamItemRecord,
   itemPath: Path,
 ): Promise<IteratorResult<unknown>> {
+  let iteration;
   try {
-    const { value, done } = await iterator.next();
-    if (done) {
-      asyncPayloadRecord.setIsCompletedIterator();
-      return { done, value: undefined };
-    }
-    return {
-      done: false,
-      value: completeValueCatchingErrors(
-        exeContext,
-        itemType,
-        fieldNodes,
-        info,
-        itemPath,
-        value,
-        asyncPayloadRecord,
-      ),
-    };
+    iteration = await iterator.next();
   } catch (rawError) {
     const error = locatedError(rawError, fieldNodes, pathToArray(itemPath));
     const value = handleFieldError(error, itemType, asyncPayloadRecord.errors);
     // don't continue if iterator throws
     return { done: true, value };
   }
+
+  const { value, done } = iteration;
+
+  if (done) {
+    asyncPayloadRecord.setIsCompletedIterator();
+    return { done, value: undefined };
+  }
+  return {
+    done: false,
+    value: completeValueCatchingErrors(
+      exeContext,
+      itemType,
+      fieldNodes,
+      info,
+      itemPath,
+      value,
+      asyncPayloadRecord,
+    ),
+  };
 }
 
 async function executeStreamAsyncIterator(