remove explicit 'iter' loops (clippy::explicit_iter_loop)

Author: daniel.eades

graphql_client_cli/src/introspection_schema.rs

@@ -151,14 +151,12 @@ mod tests {
     fn it_errors_invalid_headers() {
         // https://tools.ietf.org/html/rfc7230#section-3.2
 
-        for input in [
+        for input in &[
             "X-Name Value",   // error: colon required for name/value pair
             ": Value",        // error: field name must be
             "X Name: Value",  // error: no whitespace in field name
             "X\tName: Value", // error: no whitespace in field name (tab)
-        ]
-        .iter()
-        {
+        ] {
             let header = Header::from_str(input);
 
             assert!(header.is_err(), "Expected error: [{}]", input);
@@ -178,7 +176,7 @@ mod tests {
             value: "Value:".to_string(),
         };
 
-        for (input, expected) in [
+        for (input, expected) in &[
             ("X-Name: Value", &expected1),  // ideal
             ("X-Name:Value", &expected1),   // no optional whitespace
             ("X-Name: Value ", &expected1), // with optional whitespace
@@ -187,9 +185,7 @@ mod tests {
             // not allowed per RFC, but we'll forgive
             ("X-Name : Value", &expected1),
             (" X-Name: Value", &expected1),
-        ]
-        .iter()
-        {
+        ] {
             let header = Header::from_str(input);
 
             assert!(header.is_ok(), "Expected ok: [{}]", input);

graphql_client_codegen/src/query.rs

@@ -252,7 +252,7 @@ fn resolve_union_selection<'doc, T>(
 where
     T: graphql_parser::query::Text<'doc>,
 {
-    for item in selection_set.items.iter() {
+    for item in &selection_set.items {
         match item {
             graphql_parser::query::Selection::Field(field) => {
                 if field.name.as_ref() == TYPENAME_FIELD {
@@ -298,7 +298,7 @@ fn resolve_object_selection<'a, 'doc, T>(
 where
     T: graphql_parser::query::Text<'doc>,
 {
-    for item in selection_set.items.iter() {
+    for item in &selection_set.items {
         match item {
             graphql_parser::query::Selection::Field(field) => {
                 if field.name.as_ref() == TYPENAME_FIELD {

graphql_client_codegen/src/query/validation.rs

@@ -4,7 +4,7 @@ use crate::schema::TypeId;
 pub(super) fn validate_typename_presence(
     query: &BoundQuery<'_>,
 ) -> Result<(), QueryValidationError> {
-    for fragment in query.query.fragments.iter() {
+    for fragment in &query.query.fragments {
         let type_id = match fragment.on {
             id @ TypeId::Interface(_) | id @ TypeId::Union(_) => id,
             _ => continue,

graphql_client_codegen/src/schema/graphql_parser_conversion.rs

@@ -179,7 +179,7 @@ fn ingest_object<'doc, T>(
         .unwrap();
     let mut field_ids = Vec::with_capacity(obj.fields.len());
 
-    for field in obj.fields.iter_mut() {
+    for field in &mut obj.fields {
         let field = super::StoredField {
             name: field.name.as_ref().into(),
             r#type: resolve_field_type(schema, &field.field_type),
@@ -216,7 +216,7 @@ fn ingest_object_type_extension<'doc, T>(
         .unwrap();
     let mut field_ids = Vec::with_capacity(ext.fields.len());
 
-    for field in ext.fields.iter_mut() {
+    for field in &mut ext.fields {
         let field = super::StoredField {
             name: field.name.as_ref().into(),
             r#type: resolve_field_type(schema, &field.field_type),
@@ -285,7 +285,7 @@ fn ingest_interface<'doc, T>(
 
     let mut field_ids = Vec::with_capacity(interface.fields.len());
 
-    for field in interface.fields.iter_mut() {
+    for field in &mut interface.fields {
         let field = super::StoredField {
             name: field.name.as_ref().into(),
             r#type: resolve_field_type(schema, &field.field_type),

graphql_query_derive/src/attributes.rs

@@ -20,7 +20,7 @@ pub fn ident_exists(ast: &syn::DeriveInput, ident: &str) -> Result<(), syn::Erro
         .ok_or_else(|| syn::Error::new_spanned(ast, "The graphql attribute is missing"))?;
 
     if let syn::Meta::List(items) = &attribute.parse_meta().expect("Attribute is well formatted") {
-        for item in items.nested.iter() {
+        for item in &items.nested {
             if let syn::NestedMeta::Meta(syn::Meta::Path(path)) = item {
                 if let Some(ident_) = path.get_ident() {
                     if ident_ == ident {
@@ -46,7 +46,7 @@ pub fn extract_attr(ast: &syn::DeriveInput, attr: &str) -> Result<String, syn::E
         .find(|attr| attr.path == graphql_path)
         .ok_or_else(|| syn::Error::new_spanned(ast, "The graphql attribute is missing"))?;
     if let syn::Meta::List(items) = &attribute.parse_meta().expect("Attribute is well formatted") {
-        for item in items.nested.iter() {
+        for item in &items.nested {
             if let syn::NestedMeta::Meta(syn::Meta::NameValue(name_value)) = item {
                 let syn::MetaNameValue { path, lit, .. } = name_value;
                 if let Some(ident) = path.get_ident() {
@@ -75,7 +75,7 @@ pub fn extract_attr_list(ast: &syn::DeriveInput, attr: &str) -> Result<Vec<Strin
         .find(|attr| attr.path == graphql_path)
         .ok_or_else(|| syn::Error::new_spanned(ast, "The graphql attribute is missing"))?;
     if let syn::Meta::List(items) = &attribute.parse_meta().expect("Attribute is well formatted") {
-        for item in items.nested.iter() {
+        for item in &items.nested {
             if let syn::NestedMeta::Meta(syn::Meta::List(value_list)) = item {
                 if let Some(ident) = value_list.path.get_ident() {
                     if ident == attr {