Skip to content

Commit faa6c49

Browse files
committed
Change name of ObjectMapperConfigurer to prevent conflict with graphql-java-tools fix #234
1 parent f08daf9 commit faa6c49

File tree

6 files changed

+13
-13
lines changed

6 files changed

+13
-13
lines changed

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version = 9.0.1
1+
version = 9.1.0
22
group = com.graphql-java-kickstart
33

44
PROJECT_NAME = graphql-java-servlet

graphql-java-kickstart/src/main/java/graphql/kickstart/execution/GraphQLObjectMapper.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import graphql.GraphQLError;
1515
import graphql.execution.ExecutionPath;
1616
import graphql.kickstart.execution.config.ConfiguringObjectMapperProvider;
17-
import graphql.kickstart.execution.config.ObjectMapperConfigurer;
17+
import graphql.kickstart.execution.config.GraphQLServletObjectMapperConfigurer;
1818
import graphql.kickstart.execution.config.ObjectMapperProvider;
1919
import graphql.kickstart.execution.error.DefaultGraphQLErrorHandler;
2020
import graphql.kickstart.execution.error.GraphQLErrorHandler;
@@ -192,11 +192,11 @@ public static class Builder {
192192
private ObjectMapperProvider objectMapperProvider = new ConfiguringObjectMapperProvider();
193193
private Supplier<GraphQLErrorHandler> graphQLErrorHandler = DefaultGraphQLErrorHandler::new;
194194

195-
public Builder withObjectMapperConfigurer(ObjectMapperConfigurer objectMapperConfigurer) {
195+
public Builder withObjectMapperConfigurer(GraphQLServletObjectMapperConfigurer objectMapperConfigurer) {
196196
return withObjectMapperConfigurer(() -> objectMapperConfigurer);
197197
}
198198

199-
public Builder withObjectMapperConfigurer(Supplier<ObjectMapperConfigurer> objectMapperConfigurer) {
199+
public Builder withObjectMapperConfigurer(Supplier<GraphQLServletObjectMapperConfigurer> objectMapperConfigurer) {
200200
this.objectMapperProvider = new ConfiguringObjectMapperProvider(objectMapperConfigurer.get());
201201
return this;
202202
}

graphql-java-kickstart/src/main/java/graphql/kickstart/execution/config/ConfiguringObjectMapperProvider.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
package graphql.kickstart.execution.config;
22

33
import com.fasterxml.jackson.databind.ObjectMapper;
4-
import graphql.kickstart.execution.error.DefaultObjectMapperConfigurer;
4+
import graphql.kickstart.execution.error.DefaultGraphQLServletObjectMapperConfigurer;
55

66
public class ConfiguringObjectMapperProvider implements ObjectMapperProvider {
77

88
private final ObjectMapper objectMapperTemplate;
99

10-
private final ObjectMapperConfigurer objectMapperConfigurer;
10+
private final GraphQLServletObjectMapperConfigurer objectMapperConfigurer;
1111

12-
public ConfiguringObjectMapperProvider(ObjectMapper objectMapperTemplate, ObjectMapperConfigurer objectMapperConfigurer) {
12+
public ConfiguringObjectMapperProvider(ObjectMapper objectMapperTemplate, GraphQLServletObjectMapperConfigurer objectMapperConfigurer) {
1313
this.objectMapperTemplate = objectMapperTemplate == null ? new ObjectMapper() : objectMapperTemplate;
14-
this.objectMapperConfigurer = objectMapperConfigurer == null ? new DefaultObjectMapperConfigurer() : objectMapperConfigurer;
14+
this.objectMapperConfigurer = objectMapperConfigurer == null ? new DefaultGraphQLServletObjectMapperConfigurer() : objectMapperConfigurer;
1515
}
1616

1717
public ConfiguringObjectMapperProvider(ObjectMapper objectMapperTemplate) {
1818
this(objectMapperTemplate, null);
1919
}
2020

21-
public ConfiguringObjectMapperProvider(ObjectMapperConfigurer objectMapperConfigurer) {
21+
public ConfiguringObjectMapperProvider(GraphQLServletObjectMapperConfigurer objectMapperConfigurer) {
2222
this(null, objectMapperConfigurer);
2323
}
2424

graphql-java-kickstart/src/main/java/graphql/kickstart/execution/config/ObjectMapperConfigurer.java renamed to graphql-java-kickstart/src/main/java/graphql/kickstart/execution/config/GraphQLServletObjectMapperConfigurer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
/**
66
* @author Andrew Potter
77
*/
8-
public interface ObjectMapperConfigurer {
8+
public interface GraphQLServletObjectMapperConfigurer {
99
void configure(ObjectMapper mapper);
1010
}

graphql-java-kickstart/src/main/java/graphql/kickstart/execution/error/DefaultObjectMapperConfigurer.java renamed to graphql-java-kickstart/src/main/java/graphql/kickstart/execution/error/DefaultGraphQLServletObjectMapperConfigurer.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
import com.fasterxml.jackson.databind.ObjectMapper;
55
import com.fasterxml.jackson.databind.SerializationFeature;
66
import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
7-
import graphql.kickstart.execution.config.ObjectMapperConfigurer;
7+
import graphql.kickstart.execution.config.GraphQLServletObjectMapperConfigurer;
88

99
/**
1010
* @author Andrew Potter
1111
*/
12-
public class DefaultObjectMapperConfigurer implements ObjectMapperConfigurer {
12+
public class DefaultGraphQLServletObjectMapperConfigurer implements GraphQLServletObjectMapperConfigurer {
1313

1414
@Override
1515
public void configure(ObjectMapper mapper) {

travis-build.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ EOL
1414
chmod 600 $HOME/.netrc
1515
}
1616

17-
if [ "${TRAVIS_PULL_REQUEST}" = "false" ] && [ "${TRAVIS_BRANCH}" = "master" ]; then
17+
if [ "${TRAVIS_PULL_REQUEST}" = "false" ] && [ "${TRAVIS_BRANCH}" = "master" ] && [ "${RELEASE}" = "true" ]; then
1818
saveGitCredentials
1919
git checkout -f ${TRAVIS_BRANCH}
2020
if [ "${RELEASE}" = "true" ]; then

0 commit comments

Comments
 (0)