Ruff

Author: MoonBoi9001

src/models/service_quality_oracle.py

@@ -49,12 +49,12 @@ def main(run_date_override: date = None):
         # Configuration and credentials
         config = load_config()
         slack_notifier = create_slack_notifier(config.get("SLACK_WEBHOOK_URL"))
-        
+
         if slack_notifier:
             logger.info("Slack notifications enabled")
         else:
             logger.info("Slack notifications disabled (no webhook URL configured)")
-            
+
         credential_manager.setup_google_credentials()
 
         # Define the date for the current run

tests/test_blockchain_client.py

@@ -4,7 +4,7 @@
 
 import json
 from pathlib import Path
-from unittest.mock import MagicMock, mock_open, patch, PropertyMock
+from unittest.mock import MagicMock, PropertyMock, mock_open, patch
 
 import pytest
 import requests
@@ -84,6 +84,7 @@ def blockchain_client(mock_w3, mock_slack, mock_file):
 class TestInitializationAndConnection:
     """Tests focusing on the client's initialization and RPC connection logic."""
 
+
     def test_successful_initialization(self, blockchain_client: BlockchainClient, mock_w3, mock_file):
         """
         Tests that the BlockchainClient initializes correctly on the happy path.
@@ -103,12 +104,11 @@ def test_successful_initialization(self, blockchain_client: BlockchainClient, mo
         client.w3.is_connected.assert_called_once()
 
         # Assert contract object was created
-        client.mock_w3_instance.eth.contract.assert_called_once_with(
-            address=MOCK_CONTRACT_ADDRESS, abi=MOCK_ABI
-        )
+        client.mock_w3_instance.eth.contract.assert_called_once_with(address=MOCK_CONTRACT_ADDRESS, abi=MOCK_ABI)
         assert client.w3 is not None
         assert client.contract is not None
 
+
     def test_initialization_fails_if_abi_not_found(self, mock_w3, mock_slack):
         """
         Tests that BlockchainClient raises an exception if the ABI file cannot be found.
@@ -126,6 +126,7 @@ def test_initialization_fails_if_abi_not_found(self, mock_w3, mock_slack):
                         slack_notifier=mock_slack,
                     )
 
+
     def test_rpc_failover_mechanism(self, mock_w3, mock_slack):
         """
         Tests that the client successfully fails over to a secondary RPC if the primary fails.
@@ -135,9 +136,7 @@ def test_rpc_failover_mechanism(self, mock_w3, mock_slack):
         mock_w3_instance.is_connected.side_effect = [False, True]
 
         with patch("builtins.open", mock_open(read_data=json.dumps(MOCK_ABI))):
-            with patch(
-                "src.models.blockchain_client.Web3", MagicMock(return_value=mock_w3_instance)
-            ) as MockWeb3:
+            with patch("src.models.blockchain_client.Web3", MagicMock(return_value=mock_w3_instance)) as MockWeb3:
                 # Act
                 client = BlockchainClient(
                     rpc_providers=MOCK_RPC_PROVIDERS,
@@ -159,6 +158,7 @@ def test_rpc_failover_mechanism(self, mock_w3, mock_slack):
                 # The client should be connected and pointing to the secondary provider index
                 assert client.current_rpc_index == 1
 
+
     def test_connection_error_if_all_rpcs_fail(self, mock_w3, mock_slack):
         """
         Tests that a ConnectionError is raised if the client cannot connect to any RPC provider.
@@ -183,6 +183,7 @@ def test_connection_error_if_all_rpcs_fail(self, mock_w3, mock_slack):
                         slack_notifier=mock_slack,
                     )
 
+
     def test_execute_rpc_call_with_failover(self, blockchain_client: BlockchainClient):
         """
         Tests that _execute_rpc_call fails over to the next provider if the first one
@@ -214,6 +215,7 @@ def test_execute_rpc_call_with_failover(self, blockchain_client: BlockchainClien
         call_kwargs = blockchain_client.slack_notifier.send_info_notification.call_args.kwargs
         assert "Switching from previous RPC" in call_kwargs["message"]
 
+
     def test_execute_rpc_call_reraises_unexpected_exceptions(self, blockchain_client: BlockchainClient):
         """
         Tests that _execute_rpc_call does not attempt to failover on unexpected,
@@ -231,6 +233,7 @@ def test_execute_rpc_call_reraises_unexpected_exceptions(self, blockchain_client
         assert blockchain_client.current_rpc_index == 0
         blockchain_client.slack_notifier.send_info_notification.assert_not_called()
 
+
     def test_initialization_fails_with_empty_rpc_provider_list(self, mock_w3, mock_slack):
         """
         Tests that BlockchainClient raises an exception if initialized with an empty list of RPC providers.
@@ -252,6 +255,7 @@ def test_initialization_fails_with_empty_rpc_provider_list(self, mock_w3, mock_s
 class TestTransactionLogic:
     """Tests focusing on the helper methods for building and sending a transaction."""
 
+
     def test_setup_transaction_account_success(self, blockchain_client: BlockchainClient):
         """
         Tests that _setup_transaction_account returns the correct address and formatted key
@@ -263,12 +267,11 @@ def test_setup_transaction_account_success(self, blockchain_client: BlockchainCl
             address, key = blockchain_client._setup_transaction_account(MOCK_PRIVATE_KEY)
 
             mock_validate.assert_called_once_with(MOCK_PRIVATE_KEY)
-            blockchain_client.mock_w3_instance.eth.account.from_key.assert_called_once_with(
-                MOCK_PRIVATE_KEY
-            )
+            blockchain_client.mock_w3_instance.eth.account.from_key.assert_called_once_with(MOCK_PRIVATE_KEY)
             assert address == MOCK_SENDER_ADDRESS
             assert key == MOCK_PRIVATE_KEY
 
+
     def test_setup_transaction_account_invalid_key_raises_key_validation_error(
         self, blockchain_client: BlockchainClient
     ):
@@ -281,6 +284,7 @@ def test_setup_transaction_account_invalid_key_raises_key_validation_error(
             with pytest.raises(KeyValidationError, match="Invalid key"):
                 blockchain_client._setup_transaction_account("invalid-key")
 
+
     def test_setup_transaction_account_unexpected_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _setup_transaction_account raises a generic exception for unexpected errors.
@@ -291,6 +295,7 @@ def test_setup_transaction_account_unexpected_error(self, blockchain_client: Blo
             with pytest.raises(Exception, match="Unexpected error"):
                 blockchain_client._setup_transaction_account("any-key")
 
+
     def test_estimate_transaction_gas_success(self, blockchain_client: BlockchainClient):
         """
         Tests that _estimate_transaction_gas correctly estimates gas and adds a 25% buffer.
@@ -310,9 +315,8 @@ def test_estimate_transaction_gas_success(self, blockchain_client: BlockchainCli
 
         # Assert
         assert gas_limit == 125_000  # 100_000 * 1.25
-        mock_contract_func.return_value.estimate_gas.assert_called_once_with(
-            {"from": MOCK_SENDER_ADDRESS}
-        )
+        mock_contract_func.return_value.estimate_gas.assert_called_once_with({"from": MOCK_SENDER_ADDRESS})
+
 
     def test_estimate_transaction_gas_failure(self, blockchain_client: BlockchainClient):
         """
@@ -331,6 +335,7 @@ def test_estimate_transaction_gas_failure(self, blockchain_client: BlockchainCli
                 sender_address=MOCK_SENDER_ADDRESS,
             )
 
+
     def test_determine_transaction_nonce_new(self, blockchain_client: BlockchainClient):
         """
         Tests that the next available nonce is fetched for a new transaction (replace=False).
@@ -344,9 +349,8 @@ def test_determine_transaction_nonce_new(self, blockchain_client: BlockchainClie
 
         # Assert
         assert nonce == expected_nonce
-        blockchain_client.mock_w3_instance.eth.get_transaction_count.assert_called_once_with(
-            MOCK_SENDER_ADDRESS
-        )
+        blockchain_client.mock_w3_instance.eth.get_transaction_count.assert_called_once_with(MOCK_SENDER_ADDRESS)
+
 
     def test_determine_transaction_nonce_replace(self, blockchain_client: BlockchainClient):
         """
@@ -368,15 +372,15 @@ def test_determine_transaction_nonce_replace(self, blockchain_client: Blockchain
 
         # Assert
         assert nonce == 12
-        blockchain_client.mock_w3_instance.eth.get_block.assert_called_once_with(
-            "pending", full_transactions=True
-        )
+        blockchain_client.mock_w3_instance.eth.get_block.assert_called_once_with("pending", full_transactions=True)
+
 
     def test_determine_transaction_nonce_replace_no_pending_tx_with_nonce_gap(
         self, blockchain_client: BlockchainClient
     ):
         """
-        Tests that nonce determination falls back to the latest nonce if no pending txs are found but a nonce gap exists.
+        Tests that nonce determination falls back to the latest nonce
+        if no pending txs are found but a nonce gap exists.
         """
         # Arrange
         blockchain_client.mock_w3_instance.eth.get_block.return_value = {"transactions": []}
@@ -392,6 +396,7 @@ def test_determine_transaction_nonce_replace_no_pending_tx_with_nonce_gap(
         assert nonce == 9  # Should use the latest nonce from the gap
         assert blockchain_client.mock_w3_instance.eth.get_transaction_count.call_count == 2
 
+
     def test_determine_transaction_nonce_replace_no_pending_tx_no_gap_fallback(
         self, blockchain_client: BlockchainClient
     ):
@@ -415,6 +420,7 @@ def test_determine_transaction_nonce_replace_no_pending_tx_no_gap_fallback(
         w3_instance.eth.get_block.assert_called_once_with("pending", full_transactions=True)
         assert w3_instance.eth.get_transaction_count.call_count == 3
 
+
     def test_determine_transaction_nonce_replace_handles_errors(self, blockchain_client: BlockchainClient):
         """
         Tests that nonce determination falls back gracefully if checking for pending
@@ -433,6 +439,7 @@ def test_determine_transaction_nonce_replace_handles_errors(self, blockchain_cli
         w3_instance.eth.get_block.assert_called_once()
         w3_instance.eth.get_transaction_count.assert_called()
 
+
     def test_get_gas_prices_success(self, blockchain_client: BlockchainClient):
         """
         Tests that _get_gas_prices successfully fetches and returns the base and priority fees.
@@ -451,6 +458,7 @@ def test_get_gas_prices_success(self, blockchain_client: BlockchainClient):
         assert base_fee == mock_base_fee
         assert max_priority_fee == mock_priority_fee
 
+
     def test_get_gas_prices_fallback_on_base_fee_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _get_gas_prices falls back to a default base fee if the RPC call fails.
@@ -466,6 +474,7 @@ def test_get_gas_prices_fallback_on_base_fee_error(self, blockchain_client: Bloc
         assert base_fee == 10 * 10**9
         blockchain_client.mock_w3_instance.to_wei.assert_called_once_with(10, "gwei")
 
+
     def test_get_gas_prices_fallback_on_priority_fee_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _get_gas_prices falls back to a default priority fee if the RPC call fails.
@@ -483,6 +492,7 @@ def test_get_gas_prices_fallback_on_priority_fee_error(self, blockchain_client:
         assert max_priority_fee == 2 * 10**9
         blockchain_client.mock_w3_instance.to_wei.assert_called_once_with(2, "gwei")
 
+
     @pytest.mark.parametrize(
         "replace, expected_max_fee, expected_priority_fee",
         [
@@ -517,6 +527,7 @@ def test_build_transaction_params(
         assert tx_params["from"] == MOCK_SENDER_ADDRESS
         assert tx_params["nonce"] == 1
 
+
     def test_build_and_sign_transaction_success(self, blockchain_client: BlockchainClient):
         """
         Tests that _build_and_sign_transaction successfully builds and signs a transaction.
@@ -540,13 +551,12 @@ def test_build_and_sign_transaction_success(self, blockchain_client: BlockchainC
 
         # Assert
         assert signed_tx == mock_signed_transaction
-        mock_contract_func.return_value.build_transaction.assert_called_once_with(
-            {"from": MOCK_SENDER_ADDRESS}
-        )
+        mock_contract_func.return_value.build_transaction.assert_called_once_with({"from": MOCK_SENDER_ADDRESS})
         blockchain_client.w3.eth.account.sign_transaction.assert_called_once_with(
             mock_transaction, MOCK_PRIVATE_KEY
         )
 
+
     def test_build_and_sign_transaction_failure(self, blockchain_client: BlockchainClient):
         """
         Tests that _build_and_sign_transaction raises an exception if building fails.
@@ -565,6 +575,7 @@ def test_build_and_sign_transaction_failure(self, blockchain_client: BlockchainC
                 private_key="key",
             )
 
+
     def test_send_signed_transaction_success(self, blockchain_client: BlockchainClient):
         """
         Tests that a signed transaction is sent and its hash is returned on success.
@@ -588,6 +599,7 @@ def test_send_signed_transaction_success(self, blockchain_client: BlockchainClie
             mock_tx_hash, MOCK_TX_TIMEOUT_SECONDS
         )
 
+
     def test_send_signed_transaction_raises_exception_when_reverted(self, blockchain_client: BlockchainClient):
         """
         Tests that an exception is raised if the transaction is reverted on-chain.
@@ -606,6 +618,7 @@ def test_send_signed_transaction_raises_exception_when_reverted(self, blockchain
         ):
             blockchain_client._send_signed_transaction(mock_signed_tx)
 
+
     def test_send_signed_transaction_raises_exception_on_timeout(self, blockchain_client: BlockchainClient):
         """
         Tests that an exception is raised if waiting for the transaction receipt times out.
@@ -619,7 +632,9 @@ def test_send_signed_transaction_raises_exception_on_timeout(self, blockchain_cl
         )
 
         # Act & Assert
-        with pytest.raises(Exception, match="Error sending transaction or waiting for receipt: All RPC providers are unreachable."):
+        with pytest.raises(
+            Exception, match="Error sending transaction or waiting for receipt: All RPC providers are unreachable."
+        ):
             blockchain_client._send_signed_transaction(mock_signed_tx)
 
 
@@ -665,6 +680,7 @@ def mock_full_transaction_flow(mocker: MockerFixture):
 class TestOrchestrationAndBatching:
     """Tests focusing on the end-to-end orchestration and batch processing logic."""
 
+
     def test_execute_complete_transaction_happy_path(
         self,
         blockchain_client: BlockchainClient,
@@ -709,6 +725,7 @@ def test_execute_complete_transaction_happy_path(
         )
         mock_full_transaction_flow["send"].assert_called_once_with("signed_tx")
 
+
     def test_execute_complete_transaction_missing_params(self, blockchain_client: BlockchainClient):
         """
         Tests that _execute_complete_transaction raises ValueError if required parameters are missing.
@@ -720,6 +737,7 @@ def test_execute_complete_transaction_missing_params(self, blockchain_client: Bl
         with pytest.raises(ValueError, match="Missing required parameters for transaction."):
             blockchain_client._execute_complete_transaction(incomplete_params)
 
+
     def test_execute_complete_transaction_invalid_function(self, blockchain_client: BlockchainClient):
         """
         Tests that _execute_complete_transaction raises ValueError for a non-existent contract function.
@@ -742,6 +760,7 @@ def test_execute_complete_transaction_invalid_function(self, blockchain_client:
         ):
             blockchain_client._execute_complete_transaction(params)
 
+
     def test_send_transaction_to_allow_indexers_orchestration(
         self, blockchain_client: BlockchainClient, mocker: MockerFixture
     ):
@@ -772,6 +791,7 @@ def test_send_transaction_to_allow_indexers_orchestration(
         assert call_args["contract_function"] == "allow"
         assert call_args["replace"] is False
 
+
     def test_batch_processing_splits_correctly(self, blockchain_client: BlockchainClient):
         """
         Tests that the batch processing logic correctly splits a list of addresses
@@ -801,6 +821,7 @@ def test_batch_processing_splits_correctly(self, blockchain_client: BlockchainCl
         assert blockchain_client.send_transaction_to_allow_indexers.call_args_list[1][0][0] == addresses[2:4]
         assert blockchain_client.send_transaction_to_allow_indexers.call_args_list[2][0][0] == addresses[4:5]
 
+
     def test_batch_processing_halts_on_failure(self, blockchain_client: BlockchainClient):
         """
         Tests that the batch processing halts immediately if one of the transactions fails.
@@ -827,6 +848,7 @@ def test_batch_processing_halts_on_failure(self, blockchain_client: BlockchainCl
         # The method should have only been called twice (the first success, the second failure)
         assert blockchain_client.send_transaction_to_allow_indexers.call_count == 2
 
+
     def test_batch_processing_handles_empty_list(self, blockchain_client: BlockchainClient):
         """
         Tests that batch processing handles an empty list of addresses gracefully.