Improve unit tests for the service quality oracle core module

Author: MoonBoi9001

src/models/service_quality_oracle.py

@@ -117,15 +117,18 @@ def main(run_date_override: date = None):
         logger.info(f"Oracle run completed successfully in {execution_time:.2f} seconds")
 
         if slack_notifier:
-            batch_count = len(transaction_links) if transaction_links else 0
-            total_processed = len(eligible_indexers)
-            slack_notifier.send_success_notification(
-                eligible_indexers=eligible_indexers,
-                total_processed=total_processed,
-                execution_time=execution_time,
-                transaction_links=transaction_links,
-                batch_count=batch_count,
-            )
+            try:
+                batch_count = len(transaction_links) if transaction_links else 0
+                total_processed = len(eligible_indexers)
+                slack_notifier.send_success_notification(
+                    eligible_indexers=eligible_indexers,
+                    total_processed=total_processed,
+                    execution_time=execution_time,
+                    transaction_links=transaction_links,
+                    batch_count=batch_count,
+                )
+            except Exception as e:
+                logger.error(f"Failed to send Slack success notification: {e}", exc_info=True)
 
     except Exception as e:
         execution_time = time.time() - start_time

src/utils/slack_notifier.py

@@ -30,7 +30,11 @@ def __init__(self, webhook_url: str) -> None:
 
 
     @retry_with_backoff(
-        max_attempts=8, min_wait=1, max_wait=128, exceptions=(requests.exceptions.RequestException,)
+        max_attempts=8,
+        min_wait=1,
+        max_wait=128,
+        exceptions=(requests.exceptions.RequestException,),
+        reraise=True,
     )
     def _send_message(self, payload: Dict) -> bool:
         """
@@ -40,37 +44,28 @@ def _send_message(self, payload: Dict) -> bool:
             payload: The message payload to send
 
         Returns:
-            bool: True if message was sent successfully, False otherwise
+            bool: True if message was sent successfully.
+        Raises:
+            requests.exceptions.RequestException: If the request fails after all retries.
         """
         # Get the message type from the payload
         message_type = payload.get("text", "Unknown")
 
         # Log the message type
         logger.info(f"Sending Slack notification: {message_type}")
 
-        try:
-            response = requests.post(
-                self.webhook_url,
-                json=payload,
-                timeout=self.timeout,
-                headers={"Content-Type": "application/json"},
-            )
-
-            # If the message is sent successfully, return True
-            if response.status_code == 200:
-                logger.info("Slack notification sent successfully")
-                return True
-            else:
-                # log message failure
-                logger.warning(f"Slack notification failed: {response.status_code}")
-                # Raise an exception to trigger retry
-                response.raise_for_status()
-                return False
-
-        # If there is an error when trying to send the message, log the error and re-raise
-        except requests.exceptions.RequestException as e:
-            logger.warning(f"Slack notification failed: {str(e)}")
-            raise
+        response = requests.post(
+            self.webhook_url,
+            json=payload,
+            timeout=self.timeout,
+            headers={"Content-Type": "application/json"},
+        )
+        # Raise an exception for 4xx/5xx responses
+        response.raise_for_status()
+
+        # If the message is sent successfully, return True
+        logger.info("Slack notification sent successfully")
+        return True
 
 
     def _create_payload(self, text: str, fields: List[Dict], color: str = "good") -> Dict: