Rename tests for consistent naming across test modules

Author: MoonBoi9001

tests/test_bigquery_provider.py

@@ -67,7 +67,7 @@ class TestInitialization:
     """Tests for the __init__ method."""
 
 
-    def test_initialization_sets_bigquery_options_and_instance_vars(
+    def test_init_sets_bigquery_options_and_instance_vars(
         self, provider: BigQueryProvider, mock_bpd: MagicMock
     ):
         """
@@ -98,7 +98,7 @@ def test_get_indexer_eligibility_query_matches_snapshot(self, provider: BigQuery
         snapshot.assert_match(query, "indexer_eligibility_query.sql")
 
 
-    def test_get_indexer_eligibility_query_with_single_day_range(self, provider: BigQueryProvider):
+    def test_get_indexer_eligibility_query_handles_single_day_range(self, provider: BigQueryProvider):
         """
         Tests that the query is constructed correctly when start and end dates are the same,
         covering an edge case for a single-day analysis period.
@@ -108,7 +108,7 @@ def test_get_indexer_eligibility_query_with_single_day_range(self, provider: Big
         assert f"BETWEEN '{SINGLE_DATE.strftime('%Y-%m-%d')}' AND '{SINGLE_DATE.strftime('%Y-%m-%d')}'" in query
 
 
-    def test_get_indexer_eligibility_query_with_invalid_date_range(self, provider: BigQueryProvider):
+    def test_get_indexer_eligibility_query_handles_invalid_date_range(self, provider: BigQueryProvider):
         """
         Tests that the query is constructed correctly even with a logically invalid
         date range (start > end), which should result in an empty set from BigQuery
@@ -127,7 +127,7 @@ class TestReadGbqDataframe:
     """Tests for the _read_gbq_dataframe method."""
 
 
-    def test_read_gbq_dataframe_success(
+    def test_read_gbq_dataframe_succeeds_on_happy_path(
         self, mock_sleep: MagicMock, provider: BigQueryProvider, mock_bpd: MagicMock
     ):
         """
@@ -148,7 +148,7 @@ def test_read_gbq_dataframe_success(
 
 
     @pytest.mark.parametrize("exception_to_raise", RETRYABLE_EXCEPTIONS)
-    def test_read_gbq_dataframe_on_retryable_error_succeeds(
+    def test_read_gbq_dataframe_succeeds_after_retrying_on_error(
         self, mock_sleep: MagicMock, exception_to_raise: Exception, provider: BigQueryProvider, mock_bpd: MagicMock
     ):
         """
@@ -170,7 +170,7 @@ def test_read_gbq_dataframe_on_retryable_error_succeeds(
         pd.testing.assert_frame_equal(result_df, MOCK_DATAFRAME)
 
 
-    def test_read_gbq_dataframe_on_persistent_error_fails(
+    def test_read_gbq_dataframe_fails_on_persistent_error(
         self, mock_sleep: MagicMock, provider: BigQueryProvider, mock_bpd: MagicMock
     ):
         """
@@ -191,7 +191,7 @@ def test_read_gbq_dataframe_on_persistent_error_fails(
         mock_sleep.assert_not_called()
 
 
-    def test_read_gbq_dataframe_on_non_retryable_error_fails_immediately(
+    def test_read_gbq_dataframe_fails_immediately_on_non_retryable_error(
         self, mock_sleep: MagicMock, provider: BigQueryProvider, mock_bpd: MagicMock
     ):
         """
@@ -214,7 +214,7 @@ class TestFetchIndexerIssuanceEligibilityData:
     """Tests for the main fetch_indexer_issuance_eligibility_data method."""
 
 
-    def test_fetch_data_happy_path(self, provider: BigQueryProvider):
+    def test_fetch_indexer_issuance_eligibility_data_succeeds_on_happy_path(self, provider: BigQueryProvider):
         """
         Tests the happy path for `fetch_indexer_issuance_eligibility_data`, ensuring it
         orchestrates calls correctly and returns the final DataFrame.
@@ -238,7 +238,9 @@ def test_fetch_data_happy_path(self, provider: BigQueryProvider):
         pd.testing.assert_frame_equal(result_df, MOCK_DATAFRAME)
 
 
-    def test_fetch_data_with_empty_result_returns_empty_dataframe(self, provider: BigQueryProvider):
+    def test_fetch_indexer_issuance_eligibility_data_returns_empty_dataframe_on_empty_result(
+        self, provider: BigQueryProvider
+    ):
         """
         Tests that the method gracefully handles and returns an empty DataFrame from BigQuery.
         """
@@ -262,7 +264,9 @@ def test_fetch_data_with_empty_result_returns_empty_dataframe(self, provider: Bi
         pd.testing.assert_frame_equal(result_df, MOCK_EMPTY_DATAFRAME)
 
 
-    def test_fetch_data_on_read_error_propagates_exception(self, provider: BigQueryProvider):
+    def test_fetch_indexer_issuance_eligibility_data_propagates_exception_on_read_error(
+        self, provider: BigQueryProvider
+    ):
         """
         Tests that an exception from `_read_gbq_dataframe` is correctly propagated.
         """

tests/test_blockchain_client.py

@@ -85,7 +85,7 @@ class TestInitializationAndConnection:
     """Tests focusing on the client's initialization and RPC connection logic."""
 
 
-    def test_successful_initialization(self, blockchain_client: BlockchainClient, mock_w3, mock_file):
+    def test_init_succeeds_on_happy_path(self, blockchain_client: BlockchainClient, mock_w3, mock_file):
         """
         Tests that the BlockchainClient initializes correctly on the happy path.
         """
@@ -109,7 +109,7 @@ def test_successful_initialization(self, blockchain_client: BlockchainClient, mo
         assert client.contract is not None
 
 
-    def test_initialization_fails_if_abi_not_found(self, mock_w3, mock_slack):
+    def test_init_fails_if_abi_not_found(self, mock_w3, mock_slack):
         """
         Tests that BlockchainClient raises an exception if the ABI file cannot be found.
         """
@@ -127,7 +127,7 @@ def test_initialization_fails_if_abi_not_found(self, mock_w3, mock_slack):
                     )
 
 
-    def test_rpc_failover_mechanism(self, mock_w3, mock_slack):
+    def test_init_failover_succeeds_if_primary_rpc_fails(self, mock_w3, mock_slack):
         """
         Tests that the client successfully fails over to a secondary RPC if the primary fails.
         """
@@ -159,7 +159,7 @@ def test_rpc_failover_mechanism(self, mock_w3, mock_slack):
                 assert client.current_rpc_index == 1
 
 
-    def test_connection_error_if_all_rpcs_fail(self, mock_w3, mock_slack):
+    def test_init_fails_if_all_rpcs_fail(self, mock_w3, mock_slack):
         """
         Tests that a ConnectionError is raised if the client cannot connect to any RPC provider.
         """
@@ -184,7 +184,7 @@ def test_connection_error_if_all_rpcs_fail(self, mock_w3, mock_slack):
                     )
 
 
-    def test_execute_rpc_call_with_failover(self, blockchain_client: BlockchainClient):
+    def test_execute_rpc_call_failover_succeeds_on_connection_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _execute_rpc_call fails over to the next provider if the first one
         is unreachable, and sends a Slack notification.
@@ -216,7 +216,7 @@ def test_execute_rpc_call_with_failover(self, blockchain_client: BlockchainClien
         assert "Switching from previous RPC" in call_kwargs["message"]
 
 
-    def test_execute_rpc_call_reraises_unexpected_exceptions(self, blockchain_client: BlockchainClient):
+    def test_execute_rpc_call_reraises_unexpected_exception(self, blockchain_client: BlockchainClient):
         """
         Tests that _execute_rpc_call does not attempt to failover on unexpected,
         non-network errors and instead re-raises them immediately.
@@ -234,7 +234,7 @@ def test_execute_rpc_call_reraises_unexpected_exceptions(self, blockchain_client
         blockchain_client.slack_notifier.send_info_notification.assert_not_called()
 
 
-    def test_initialization_fails_with_empty_rpc_provider_list(self, mock_w3, mock_slack):
+    def test_init_fails_with_empty_rpc_list(self, mock_w3, mock_slack):
         """
         Tests that BlockchainClient raises an exception if initialized with an empty list of RPC providers.
         """
@@ -256,7 +256,7 @@ class TestTransactionLogic:
     """Tests focusing on the helper methods for building and sending a transaction."""
 
 
-    def test_setup_transaction_account_success(self, blockchain_client: BlockchainClient):
+    def test_setup_transaction_account_succeeds_with_valid_key(self, blockchain_client: BlockchainClient):
         """
         Tests that _setup_transaction_account returns the correct address and formatted key
         for a valid private key.
@@ -272,9 +272,7 @@ def test_setup_transaction_account_success(self, blockchain_client: BlockchainCl
             assert key == MOCK_PRIVATE_KEY
 
 
-    def test_setup_transaction_account_invalid_key_raises_key_validation_error(
-        self, blockchain_client: BlockchainClient
-    ):
+    def test_setup_transaction_account_fails_with_invalid_key(self, blockchain_client: BlockchainClient):
         """
         Tests that _setup_transaction_account raises KeyValidationError for an invalid key.
         """
@@ -285,7 +283,7 @@ def test_setup_transaction_account_invalid_key_raises_key_validation_error(
                 blockchain_client._setup_transaction_account("invalid-key")
 
 
-    def test_setup_transaction_account_unexpected_error(self, blockchain_client: BlockchainClient):
+    def test_setup_transaction_account_fails_on_unexpected_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _setup_transaction_account raises a generic exception for unexpected errors.
         """
@@ -296,7 +294,7 @@ def test_setup_transaction_account_unexpected_error(self, blockchain_client: Blo
                 blockchain_client._setup_transaction_account("any-key")
 
 
-    def test_estimate_transaction_gas_success(self, blockchain_client: BlockchainClient):
+    def test_estimate_transaction_gas_succeeds_and_adds_buffer(self, blockchain_client: BlockchainClient):
         """
         Tests that _estimate_transaction_gas correctly estimates gas and adds a 25% buffer.
         """
@@ -318,7 +316,7 @@ def test_estimate_transaction_gas_success(self, blockchain_client: BlockchainCli
         mock_contract_func.return_value.estimate_gas.assert_called_once_with({"from": MOCK_SENDER_ADDRESS})
 
 
-    def test_estimate_transaction_gas_failure(self, blockchain_client: BlockchainClient):
+    def test_estimate_transaction_gas_fails_on_rpc_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _estimate_transaction_gas raises an exception if the RPC call fails.
         """
@@ -336,7 +334,7 @@ def test_estimate_transaction_gas_failure(self, blockchain_client: BlockchainCli
             )
 
 
-    def test_determine_transaction_nonce_new(self, blockchain_client: BlockchainClient):
+    def test_determine_transaction_nonce_fetches_next_nonce_for_new_tx(self, blockchain_client: BlockchainClient):
         """
         Tests that the next available nonce is fetched for a new transaction (replace=False).
         """
@@ -352,7 +350,9 @@ def test_determine_transaction_nonce_new(self, blockchain_client: BlockchainClie
         blockchain_client.mock_w3_instance.eth.get_transaction_count.assert_called_once_with(MOCK_SENDER_ADDRESS)
 
 
-    def test_determine_transaction_nonce_replace(self, blockchain_client: BlockchainClient):
+    def test_determine_transaction_nonce_uses_oldest_pending_for_replacement(
+        self, blockchain_client: BlockchainClient
+    ):
         """
         Tests that the nonce of the oldest pending transaction is used for replacement (replace=True).
         """
@@ -375,9 +375,7 @@ def test_determine_transaction_nonce_replace(self, blockchain_client: Blockchain
         blockchain_client.mock_w3_instance.eth.get_block.assert_called_once_with("pending", full_transactions=True)
 
 
-    def test_determine_transaction_nonce_replace_no_pending_tx_with_nonce_gap(
-        self, blockchain_client: BlockchainClient
-    ):
+    def test_determine_transaction_nonce_falls_back_to_latest_on_nonce_gap(self, blockchain_client: BlockchainClient):
         """
         Tests that nonce determination falls back to the latest nonce
         if no pending txs are found but a nonce gap exists.
@@ -397,7 +395,7 @@ def test_determine_transaction_nonce_replace_no_pending_tx_with_nonce_gap(
         assert blockchain_client.mock_w3_instance.eth.get_transaction_count.call_count == 2
 
 
-    def test_determine_transaction_nonce_replace_no_pending_tx_no_gap_fallback(
+    def test_determine_transaction_nonce_falls_back_to_standard_if_no_pending_or_gap(
         self, blockchain_client: BlockchainClient
     ):
         """
@@ -421,7 +419,7 @@ def test_determine_transaction_nonce_replace_no_pending_tx_no_gap_fallback(
         assert w3_instance.eth.get_transaction_count.call_count == 3
 
 
-    def test_determine_transaction_nonce_replace_handles_errors(self, blockchain_client: BlockchainClient):
+    def test_determine_transaction_nonce_falls_back_on_error(self, blockchain_client: BlockchainClient):
         """
         Tests that nonce determination falls back gracefully if checking for pending
         transactions fails.
@@ -440,7 +438,7 @@ def test_determine_transaction_nonce_replace_handles_errors(self, blockchain_cli
         w3_instance.eth.get_transaction_count.assert_called()
 
 
-    def test_get_gas_prices_success(self, blockchain_client: BlockchainClient):
+    def test_get_gas_prices_succeeds_on_happy_path(self, blockchain_client: BlockchainClient):
         """
         Tests that _get_gas_prices successfully fetches and returns the base and priority fees.
         """
@@ -459,7 +457,7 @@ def test_get_gas_prices_success(self, blockchain_client: BlockchainClient):
         assert max_priority_fee == mock_priority_fee
 
 
-    def test_get_gas_prices_fallback_on_base_fee_error(self, blockchain_client: BlockchainClient):
+    def test_get_gas_prices_falls_back_on_base_fee_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _get_gas_prices falls back to a default base fee if the RPC call fails.
         """
@@ -475,7 +473,7 @@ def test_get_gas_prices_fallback_on_base_fee_error(self, blockchain_client: Bloc
         blockchain_client.mock_w3_instance.to_wei.assert_called_once_with(10, "gwei")
 
 
-    def test_get_gas_prices_fallback_on_priority_fee_error(self, blockchain_client: BlockchainClient):
+    def test_get_gas_prices_falls_back_on_priority_fee_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _get_gas_prices falls back to a default priority fee if the RPC call fails.
         """
@@ -500,7 +498,7 @@ def test_get_gas_prices_fallback_on_priority_fee_error(self, blockchain_client:
             (True, 420, 20),  # Replacement: base*4 + priority*2
         ],
     )
-    def test_build_transaction_params(
+    def test_build_transaction_params_builds_correctly(
         self,
         replace,
         expected_max_fee,
@@ -528,7 +526,7 @@ def test_build_transaction_params(
         assert tx_params["nonce"] == 1
 
 
-    def test_build_and_sign_transaction_success(self, blockchain_client: BlockchainClient):
+    def test_build_and_sign_transaction_succeeds_on_happy_path(self, blockchain_client: BlockchainClient):
         """
         Tests that _build_and_sign_transaction successfully builds and signs a transaction.
         """
@@ -557,7 +555,7 @@ def test_build_and_sign_transaction_success(self, blockchain_client: BlockchainC
         )
 
 
-    def test_build_and_sign_transaction_failure(self, blockchain_client: BlockchainClient):
+    def test_build_and_sign_transaction_fails_on_build_error(self, blockchain_client: BlockchainClient):
         """
         Tests that _build_and_sign_transaction raises an exception if building fails.
         """
@@ -576,7 +574,7 @@ def test_build_and_sign_transaction_failure(self, blockchain_client: BlockchainC
             )
 
 
-    def test_send_signed_transaction_success(self, blockchain_client: BlockchainClient):
+    def test_send_signed_transaction_succeeds_on_happy_path(self, blockchain_client: BlockchainClient):
         """
         Tests that a signed transaction is sent and its hash is returned on success.
         """
@@ -600,7 +598,7 @@ def test_send_signed_transaction_success(self, blockchain_client: BlockchainClie
         )
 
 
-    def test_send_signed_transaction_raises_exception_when_reverted(self, blockchain_client: BlockchainClient):
+    def test_send_signed_transaction_fails_if_reverted(self, blockchain_client: BlockchainClient):
         """
         Tests that an exception is raised if the transaction is reverted on-chain.
         """
@@ -619,7 +617,7 @@ def test_send_signed_transaction_raises_exception_when_reverted(self, blockchain
             blockchain_client._send_signed_transaction(mock_signed_tx)
 
 
-    def test_send_signed_transaction_raises_exception_on_timeout(self, blockchain_client: BlockchainClient):
+    def test_send_signed_transaction_fails_on_timeout(self, blockchain_client: BlockchainClient):
         """
         Tests that an exception is raised if waiting for the transaction receipt times out.
         """
@@ -681,7 +679,7 @@ class TestOrchestrationAndBatching:
     """Tests focusing on the end-to-end orchestration and batch processing logic."""
 
 
-    def test_execute_complete_transaction_happy_path(
+    def test_execute_complete_transaction_succeeds_on_happy_path(
         self,
         blockchain_client: BlockchainClient,
         mocker: MockerFixture,
@@ -726,7 +724,7 @@ def test_execute_complete_transaction_happy_path(
         mock_full_transaction_flow["send"].assert_called_once_with("signed_tx")
 
 
-    def test_execute_complete_transaction_missing_params(self, blockchain_client: BlockchainClient):
+    def test_execute_complete_transaction_fails_on_missing_params(self, blockchain_client: BlockchainClient):
         """
         Tests that _execute_complete_transaction raises ValueError if required parameters are missing.
         """
@@ -738,7 +736,7 @@ def test_execute_complete_transaction_missing_params(self, blockchain_client: Bl
             blockchain_client._execute_complete_transaction(incomplete_params)
 
 
-    def test_execute_complete_transaction_invalid_function(self, blockchain_client: BlockchainClient):
+    def test_execute_complete_transaction_fails_on_invalid_function(self, blockchain_client: BlockchainClient):
         """
         Tests that _execute_complete_transaction raises ValueError for a non-existent contract function.
         """
@@ -761,7 +759,7 @@ def test_execute_complete_transaction_invalid_function(self, blockchain_client:
             blockchain_client._execute_complete_transaction(params)
 
 
-    def test_send_transaction_to_allow_indexers_orchestration(
+    def test_send_transaction_to_allow_indexers_calls_execution_method(
         self, blockchain_client: BlockchainClient, mocker: MockerFixture
     ):
         """
@@ -792,7 +790,7 @@ def test_send_transaction_to_allow_indexers_orchestration(
         assert call_args["replace"] is False
 
 
-    def test_batch_processing_splits_correctly(self, blockchain_client: BlockchainClient):
+    def test_batch_allow_indexers_splits_batches_correctly(self, blockchain_client: BlockchainClient):
         """
         Tests that the batch processing logic correctly splits a list of addresses
         into multiple transactions based on batch size.
@@ -822,7 +820,7 @@ def test_batch_processing_splits_correctly(self, blockchain_client: BlockchainCl
         assert blockchain_client.send_transaction_to_allow_indexers.call_args_list[2][0][0] == addresses[4:5]
 
 
-    def test_batch_processing_halts_on_failure(self, blockchain_client: BlockchainClient):
+    def test_batch_allow_indexers_halts_on_failure(self, blockchain_client: BlockchainClient):
         """
         Tests that the batch processing halts immediately if one of the transactions fails.
         """
@@ -849,7 +847,7 @@ def test_batch_processing_halts_on_failure(self, blockchain_client: BlockchainCl
         assert blockchain_client.send_transaction_to_allow_indexers.call_count == 2
 
 
-    def test_batch_processing_handles_empty_list(self, blockchain_client: BlockchainClient):
+    def test_batch_allow_indexers_handles_empty_list(self, blockchain_client: BlockchainClient):
         """
         Tests that batch processing handles an empty list of addresses gracefully.
         """