Improve unit tests for the slack notifier module

Author: MoonBoi9001

src/models/service_quality_oracle.py

@@ -41,19 +41,20 @@ def main(run_date_override: date = None):
         run_date_override: If provided, use this date for the run instead of today.
     """
     start_time = time.time()
-    slack_notifier = None
     stage = "Initialization"
     project_root_path = Path(__file__).resolve().parents[2]
+    slack_notifier = None
 
     try:
         # Configuration and credentials
-        credential_manager.setup_google_credentials()
         config = load_config()
         slack_notifier = create_slack_notifier(config.get("SLACK_WEBHOOK_URL"))
+
         if slack_notifier:
             logger.info("Slack notifications enabled")
         else:
             logger.info("Slack notifications disabled (no webhook URL configured)")
+        credential_manager.setup_google_credentials()
 
         # Define the date for the current run
         current_run_date = run_date_override or date.today()

src/utils/slack_notifier.py

@@ -30,7 +30,11 @@ def __init__(self, webhook_url: str) -> None:
 
 
     @retry_with_backoff(
-        max_attempts=8, min_wait=1, max_wait=128, exceptions=(requests.exceptions.RequestException,)
+        max_attempts=8,
+        min_wait=1,
+        max_wait=128,
+        exceptions=(requests.exceptions.RequestException,),
+        reraise=True,
     )
     def _send_message(self, payload: Dict) -> bool:
         """
@@ -40,37 +44,28 @@ def _send_message(self, payload: Dict) -> bool:
             payload: The message payload to send
 
         Returns:
-            bool: True if message was sent successfully, False otherwise
+            bool: True if message was sent successfully.
+        Raises:
+            requests.exceptions.RequestException: If the request fails after all retries.
         """
         # Get the message type from the payload
         message_type = payload.get("text", "Unknown")
 
         # Log the message type
         logger.info(f"Sending Slack notification: {message_type}")
 
-        try:
-            response = requests.post(
-                self.webhook_url,
-                json=payload,
-                timeout=self.timeout,
-                headers={"Content-Type": "application/json"},
-            )
-
-            # If the message is sent successfully, return True
-            if response.status_code == 200:
-                logger.info("Slack notification sent successfully")
-                return True
-            else:
-                # log message failure
-                logger.warning(f"Slack notification failed: {response.status_code}")
-                # Raise an exception to trigger retry
-                response.raise_for_status()
-                return False
-
-        # If there is an error when trying to send the message, log the error and re-raise
-        except requests.exceptions.RequestException as e:
-            logger.warning(f"Slack notification failed: {str(e)}")
-            raise
+        response = requests.post(
+            self.webhook_url,
+            json=payload,
+            timeout=self.timeout,
+            headers={"Content-Type": "application/json"},
+        )
+        # Raise an exception for 4xx/5xx responses
+        response.raise_for_status()
+
+        # If the message is sent successfully, return True
+        logger.info("Slack notification sent successfully")
+        return True
 
 
     def _create_payload(self, text: str, fields: List[Dict], color: str = "good") -> Dict:

tests/test_service_quality_oracle.py

@@ -159,8 +159,8 @@ def test_main_handles_failures_gracefully(oracle_context, failing_component, exp
         f"Oracle failed at stage '{expected_stage}': {error}", exc_info=True
     )
 
-    # If Slack notifier creation fails, no notification can be sent.
-    if failing_component == "slack_create":
+    # If config loading or Slack notifier creation fails, no notification can be sent.
+    if failing_component in ["load_config", "slack_create"]:
         ctx["slack"]["notifier"].send_failure_notification.assert_not_called()
     else:
         ctx["slack"]["notifier"].send_failure_notification.assert_called_once()
@@ -186,6 +186,7 @@ def test_main_with_no_eligible_indexers(oracle_context):
     """Test the execution path when the pipeline finds no eligible indexers."""
     ctx = oracle_context
     ctx["pipeline"].process.return_value = ([], ["0xIneligible"])
+    ctx["client"].batch_allow_indexers_issuance_eligibility.return_value = []  # No txns
 
     ctx["main"]()
 
@@ -198,6 +199,12 @@ def test_main_with_no_eligible_indexers(oracle_context):
         replace=True,
     )
     ctx["slack"]["notifier"].send_success_notification.assert_called_once()
+    # Verify the contents of the success notification for the zero-eligible case
+    call_kwargs = ctx["slack"]["notifier"].send_success_notification.call_args.kwargs
+    assert call_kwargs["eligible_indexers"] == []
+    assert call_kwargs["total_processed"] == 0
+    assert call_kwargs["transaction_links"] == []
+    assert call_kwargs["batch_count"] == 0
 
 
 def test_main_no_slack_configured(oracle_context):