chore: linting and other minor issues

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

Author: tmigone

packages/hardhat-graph-protocol/src/config.ts

@@ -1,8 +1,8 @@
 import fs from 'fs'
 import path from 'path'
 
-import { GraphPluginError } from './error'
 import { logDebug, logError } from './logger'
+import { GraphPluginError } from './error'
 
 import type { GraphDeploymentName } from '@graphprotocol/toolshed/deployments'
 import type { GraphRuntimeEnvironmentOptions } from './types'

packages/horizon/contracts/interfaces/IGraphPayments.sol

@@ -66,7 +66,7 @@ interface IGraphPayments {
     /**
      * @notice Collects funds from a payer.
      * It will pay cuts to all relevant parties and forward the rest to the receiver destination address. If the
-     * destination address is zero the funds are automatically staked to the receiver. Note that the receiver 
+     * destination address is zero the funds are automatically staked to the receiver. Note that the receiver
      * destination address can be set to the receiver address to collect funds on the receiver without re-staking.
      *
      * Note that the collected amount can be zero.

packages/horizon/contracts/mocks/imports.sol

@@ -27,4 +27,4 @@ interface IL2CurationToolshed is IL2Curation {
 
 interface IEpochManagerToolshed is IEpochManager {
     function epochLength() external view returns (uint256);
-}
+}

packages/horizon/tasks/deploy.ts

@@ -41,6 +41,7 @@ task('deploy:protocol', 'Deploy a new version of the Graph Protocol Horizon cont
 
     // Save the addresses to the address book
     console.log('\n========== 📖 Updating address book ==========')
+    // @ts-expect-error - @graphprotocol/toolshed/hardhat exports ts files so types mismatch here
     saveToAddressBook(deployment, graph.horizon.addressBook)
     console.log(`Address book at ${graph.horizon.addressBook.file} updated!`)
 
@@ -113,6 +114,7 @@ task('deploy:migrate', 'Upgrade an existing version of the Graph Protocol v1 to
 
     // Update address book
     console.log('\n========== 📖 Updating address book ==========')
+    // @ts-expect-error - @graphprotocol/toolshed/hardhat exports ts files so types mismatch here
     saveToAddressBook(deployment, graph.horizon.addressBook)
     console.log(`Address book at ${graph.horizon.addressBook.file} updated!`)
 

packages/horizon/test/deployment/Controller.test.ts

@@ -1,8 +1,8 @@
 import hre from 'hardhat'
 
 import { expect } from 'chai'
-import { toUtf8Bytes } from 'ethers'
 import { testIf } from './lib/testIf'
+import { toUtf8Bytes } from 'ethers'
 
 const graph = hre.graph()
 const addressBook = graph.horizon.addressBook

packages/horizon/test/deployment/lib/GraphProxy.test.ts

@@ -4,7 +4,7 @@ import { assert, expect } from 'chai'
 import { AddressBookEntry } from '@graphprotocol/toolshed/deployments'
 import { zeroPadValue } from 'ethers'
 
-export function graphProxyTests(contractName: string, addressBookEntry: AddressBookEntry, proxyAdmin: string, upgraded: boolean = false): void {
+export function graphProxyTests(contractName: string, addressBookEntry: AddressBookEntry, proxyAdmin: string, upgraded = false): void {
   const testIf = () => (upgraded ? it : it.skip)
 
   describe(`${contractName}: GraphProxy`, function () {

packages/horizon/test/integration/after-transition-period/upgrade.test.ts

@@ -54,7 +54,7 @@ describe('Upgrading contracts', () => {
   it('GraphPayments should be upgradeable by the governor', async () => {
     const entry = graph.horizon.addressBook.getEntry('GraphPayments')
     const proxyAdmin = entry.proxyAdmin!
-    const proxy = entry.address!
+    const proxy = entry.address
 
     // Upgrade the contract to a different implementation
     // the implementation we use is the GraphTallyCollector, this is obviously absurd but we just need an address with code on it
@@ -69,7 +69,7 @@ describe('Upgrading contracts', () => {
   it('PaymentsEscrow should be upgradeable by the governor', async () => {
     const entry = graph.horizon.addressBook.getEntry('PaymentsEscrow')
     const proxyAdmin = entry.proxyAdmin!
-    const proxy = entry.address!
+    const proxy = entry.address
 
     // Upgrade the contract to a different implementation
     // the implementation we use is the GraphTallyCollector, this is obviously absurd but we just need an address with code on it

packages/horizon/test/integration/during-transition-period/multicall.test.ts

@@ -1,8 +1,8 @@
 import hre from 'hardhat'
 
+import { ONE_MILLION, PaymentTypes } from '@graphprotocol/toolshed'
 import { ethers } from 'hardhat'
 import { expect } from 'chai'
-import { ONE_MILLION, PaymentTypes } from '@graphprotocol/toolshed'
 import { setGRTBalance } from '@graphprotocol/toolshed/hardhat'
 
 import type { HardhatEthersSigner } from '@nomicfoundation/hardhat-ethers/signers'

packages/subgraph-service/.solhintignore

@@ -0,0 +1 @@
+contracts/mocks/*

packages/subgraph-service/contracts/mocks/imports.sol

@@ -15,5 +15,5 @@ interface IL2CurationToolshed is IL2Curation {
 }
 
 interface IServiceRegistryToolshed is IServiceRegistry {
-    function services(address _indexer) external view returns (IServiceRegistry.IndexerService memory);
-}
+    function services(address indexer) external view returns (IServiceRegistry.IndexerService memory);
+}