Remove '|undefined' from abortSignal/abortPromise

Author: benjie

__tests__/getTasks.test.ts

@@ -10,6 +10,12 @@ import { makeMockJob, withPgClient } from "./helpers";
 
 const options: WorkerSharedOptions = {};
 
+const neverAbortController = new AbortController();
+const abortSignal = neverAbortController.signal;
+const abortPromise = new Promise<void>((_, reject) => {
+  abortSignal.addEventListener("abort", reject);
+});
+
 describe("commonjs", () => {
   test("gets tasks from folder", () =>
     withPgClient(async (client) => {
@@ -32,8 +38,8 @@ Array [
           withPgClient: makeEnhancedWithPgClient(
             makeWithPgClientFromClient(client),
           ),
-          abortSignal: undefined,
-          abortPromise: undefined,
+          abortSignal,
+          abortPromise,
         },
       );
       expect(await tasks.wouldyoulike!(helpers.job.payload, helpers)).toEqual(
@@ -69,8 +75,8 @@ Array [
           withPgClient: makeEnhancedWithPgClient(
             makeWithPgClientFromClient(client),
           ),
-          abortSignal: undefined,
-          abortPromise: undefined,
+          abortSignal,
+          abortPromise,
         },
       );
       expect(await tasks.task1!(helpers.job.payload, helpers)).toEqual("hi");
@@ -100,8 +106,8 @@ Array [
           withPgClient: makeEnhancedWithPgClient(
             makeWithPgClientFromClient(client),
           ),
-          abortSignal: undefined,
-          abortPromise: undefined,
+          abortSignal,
+          abortPromise,
         },
       );
       expect(await tasks.task1!(helpers.job.payload, helpers)).toEqual("hi");
@@ -130,8 +136,8 @@ Array [
         withPgClient: makeEnhancedWithPgClient(
           makeWithPgClientFromClient(client),
         ),
-        abortSignal: undefined,
-        abortPromise: undefined,
+        abortSignal,
+        abortPromise,
       });
       expect(await tasks.t1!(helpers.job.payload, helpers)).toEqual(
         "come with me",
@@ -161,8 +167,8 @@ Array [
         withPgClient: makeEnhancedWithPgClient(
           makeWithPgClientFromClient(client),
         ),
-        abortSignal: undefined,
-        abortPromise: undefined,
+        abortSignal,
+        abortPromise,
       });
       expect(await tasks.t1!(helpers.job.payload, helpers)).toEqual(
         "come with me, TS",
@@ -196,8 +202,8 @@ Array [
           withPgClient: makeEnhancedWithPgClient(
             makeWithPgClientFromClient(client),
           ),
-          abortSignal: undefined,
-          abortPromise: undefined,
+          abortSignal,
+          abortPromise,
         },
       );
       expect(await tasks.wouldyoulike!(helpers.job.payload, helpers)).toEqual(
@@ -230,8 +236,8 @@ Array [
           withPgClient: makeEnhancedWithPgClient(
             makeWithPgClientFromClient(client),
           ),
-          abortSignal: undefined,
-          abortPromise: undefined,
+          abortSignal,
+          abortPromise,
         },
       );
       expect(await tasks.task1!(helpers.job.payload, helpers)).toEqual("hi");
@@ -258,8 +264,8 @@ Array [
         withPgClient: makeEnhancedWithPgClient(
           makeWithPgClientFromClient(client),
         ),
-        abortSignal: undefined,
-        abortPromise: undefined,
+        abortSignal,
+        abortPromise,
       });
       expect(await tasks.t1!(helpers.job.payload, helpers)).toEqual(
         "come with me",

src/helpers.ts

@@ -229,8 +229,8 @@ export function makeJobHelpers(
     logger: overrideLogger,
   }: {
     withPgClient: EnhancedWithPgClient;
-    abortSignal: AbortSignal | undefined;
-    abortPromise: Promise<void> | undefined;
+    abortSignal: AbortSignal;
+    abortPromise: Promise<void>;
     logger?: Logger;
   },
 ): JobHelpers {

src/interfaces.ts

@@ -185,14 +185,14 @@ export interface JobHelpers extends Helpers {
    *
    * @experimental
    */
-  abortSignal: AbortSignal | undefined;
+  abortSignal: AbortSignal;
 
   /**
    * A promise that rejects when the AbortSignal aborts.
    *
    * @experimental
    */
-  abortPromise: Promise<void> | undefined;
+  abortPromise: Promise<void>;
 }
 
 export type CleanupTask =