Skip to content

Commit affbec3

Browse files
SirCipherSirCipher
committed
Resolves incorrect map downlink codec usage.
1 parent e141d14 commit affbec3

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

‎client/runtime/src/tests.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,7 @@ where
581581
let downlink = TrackingMapDownlink::new(
582582
spawned.clone(),
583583
stopped.clone(),
584-
MapDownlinkModel::new(set_rx, lifecycle, false),
584+
MapDownlinkModel::new(set_rx, lifecycle, true),
585585
);
586586

587587
let promise = handle

‎swimos_downlink/src/task/map.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ where
7373
lifecycle,
7474
FramedWrite::new(output, DownlinkOperationEncoder),
7575
actions,
76-
ValueNotificationDecoder::default(),
76+
MapNotificationDecoder::default(),
7777
)
7878
.instrument(info_span!("Downlink IO task.", %path))
7979
.await
@@ -84,7 +84,7 @@ where
8484
lifecycle,
8585
FramedWrite::new(output, DownlinkOperationEncoder),
8686
actions,
87-
MapNotificationDecoder::default(),
87+
ValueNotificationDecoder::default(),
8888
)
8989
.instrument(info_span!("Downlink IO task.", %path))
9090
.await

‎swimos_downlink/src/task/tests/map.rs

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ async fn link_downlink() {
9292
let (set_tx, set_rx) = mpsc::channel(16);
9393
let _handle = MapDownlinkHandle::new(set_tx);
9494
let lifecycle = make_lifecycle(event_tx);
95-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
95+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
9696

9797
let config = DownlinkConfig {
9898
events_when_not_synced: false,
@@ -122,7 +122,7 @@ async fn invalid_sync_downlink() {
122122
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
123123
let (_set_tx, set_rx) = mpsc::channel(16);
124124
let lifecycle = make_lifecycle(event_tx);
125-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
125+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
126126

127127
let config = DownlinkConfig {
128128
events_when_not_synced: false,
@@ -154,7 +154,7 @@ async fn sync_downlink() {
154154
let (set_tx, set_rx) = mpsc::channel(16);
155155
let _handle = MapDownlinkHandle::new(set_tx);
156156
let lifecycle = make_lifecycle(event_tx);
157-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
157+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
158158

159159
let config = DownlinkConfig {
160160
events_when_not_synced: false,
@@ -196,7 +196,7 @@ async fn report_events_before_sync() {
196196
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
197197
let (_set_tx, set_rx) = mpsc::channel(16);
198198
let lifecycle = make_lifecycle(event_tx);
199-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
199+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
200200

201201
let config = DownlinkConfig {
202202
events_when_not_synced: true,
@@ -247,7 +247,7 @@ async fn report_events_after_sync() {
247247
let (set_tx, set_rx) = mpsc::channel(16);
248248
let _handle = MapDownlinkHandle::new(set_tx);
249249
let lifecycle = make_lifecycle(event_tx);
250-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
250+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
251251

252252
let config = DownlinkConfig {
253253
events_when_not_synced: false,
@@ -297,7 +297,7 @@ async fn terminate_after_unlinked() {
297297
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
298298
let (_set_tx, set_rx) = mpsc::channel(16);
299299
let lifecycle = make_lifecycle(event_tx);
300-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
300+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
301301

302302
let config = DownlinkConfig {
303303
events_when_not_synced: false,
@@ -345,7 +345,7 @@ async fn terminate_after_corrupt_frame() {
345345
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
346346
let (_set_tx, set_rx) = mpsc::channel(16);
347347
let lifecycle = make_lifecycle(event_tx);
348-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
348+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
349349

350350
let config = DownlinkConfig {
351351
events_when_not_synced: false,
@@ -379,7 +379,7 @@ async fn unlink_discards_value() {
379379
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
380380
let (_set_tx, set_rx) = mpsc::channel(16);
381381
let lifecycle = make_lifecycle(event_tx);
382-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
382+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
383383

384384
let config = DownlinkConfig {
385385
events_when_not_synced: false,
@@ -427,7 +427,7 @@ async fn relink_downlink() {
427427
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
428428
let (_set_tx, set_rx) = mpsc::channel(16);
429429
let lifecycle = make_lifecycle(event_tx);
430-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
430+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
431431

432432
let config = DownlinkConfig {
433433
events_when_not_synced: false,
@@ -483,7 +483,7 @@ async fn send_on_downlink() {
483483
let (event_tx, _event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
484484
let (set_tx, set_rx) = mpsc::channel(16);
485485
let lifecycle = make_lifecycle(event_tx);
486-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
486+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
487487

488488
let config = DownlinkConfig {
489489
events_when_not_synced: false,
@@ -515,7 +515,7 @@ async fn clear_downlink() {
515515
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
516516
let (_set_tx, set_rx) = mpsc::channel(16);
517517
let lifecycle = make_lifecycle(event_tx);
518-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
518+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
519519

520520
let config = DownlinkConfig {
521521
events_when_not_synced: false,
@@ -560,7 +560,7 @@ async fn empty_sync_downlink() {
560560
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
561561
let (_set_tx, set_rx) = mpsc::channel(16);
562562
let lifecycle = make_lifecycle(event_tx);
563-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
563+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
564564

565565
let config = DownlinkConfig {
566566
events_when_not_synced: false,
@@ -594,7 +594,7 @@ async fn rx_take_elem_downlink() {
594594
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
595595
let (_set_tx, set_rx) = mpsc::channel(16);
596596
let lifecycle = make_lifecycle(event_tx);
597-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
597+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
598598

599599
let config = DownlinkConfig {
600600
events_when_not_synced: false,
@@ -663,7 +663,7 @@ async fn handle_take_elem_downlink() {
663663
let (set_tx, set_rx) = mpsc::channel(16);
664664
let handle = MapDownlinkHandle::new(set_tx);
665665
let lifecycle = make_lifecycle(event_tx);
666-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
666+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
667667

668668
let config = DownlinkConfig {
669669
events_when_not_synced: false,
@@ -714,7 +714,7 @@ async fn rx_drop_elem_downlink() {
714714
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
715715
let (_set_tx, set_rx) = mpsc::channel(16);
716716
let lifecycle = make_lifecycle(event_tx);
717-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
717+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
718718

719719
let config = DownlinkConfig {
720720
events_when_not_synced: false,
@@ -778,7 +778,7 @@ async fn handle_drop_elem_downlink() {
778778
let (set_tx, set_rx) = mpsc::channel(16);
779779
let handle = MapDownlinkHandle::new(set_tx);
780780
let lifecycle = make_lifecycle(event_tx);
781-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
781+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
782782

783783
let config = DownlinkConfig {
784784
events_when_not_synced: false,
@@ -830,7 +830,7 @@ async fn remove_elem_downlink() {
830830
let (event_tx, mut event_rx) = mpsc::unbounded_channel::<TestMessage<i32, i32>>();
831831
let (_set_tx, set_rx) = mpsc::channel(16);
832832
let lifecycle = make_lifecycle(event_tx);
833-
let model = MapDownlinkModel::new(set_rx, lifecycle, true);
833+
let model = MapDownlinkModel::new(set_rx, lifecycle, false);
834834

835835
let config = DownlinkConfig {
836836
events_when_not_synced: false,

0 commit comments

Comments
 (0)