Clippy fixes.

Author: horned-sphere

api/swimos_form/tests/structure.rs

@@ -530,7 +530,7 @@ fn test_enum_tag() {
 
     #[derive(Form, Debug, PartialEq, Clone)]
 
-    struct LogEntry<F: Form> {
+    struct LogEntry<F> {
         #[form(tag)]
         level: Level,
         #[form(header)]
@@ -559,6 +559,7 @@ fn test_enum_tag() {
 }
 
 #[test]
+#[allow(clippy::multiple_bound_locations)]
 fn generic_duplicated_bound() {
     #[derive(Form)]
 

api/swimos_model/src/text/tests.rs

@@ -661,7 +661,7 @@ fn extend_text_with_strings() {
 
 #[test]
 fn extend_text_with_strings_by_ref() {
-    let strs = vec![
+    let strs = [
         "the ".to_string(),
         "cat ".to_string(),
         "sat ".to_string(),

api/swimos_schema/src/tests.rs

@@ -1597,7 +1597,7 @@ fn form_enum_variants() {
         },
     ]);
 
-    let enums = vec![
+    let enums = [
         E::Unit,
         E::NewType(i32::max_value()),
         E::Tuple(i32::max_value(), i64::max_value(), String::from("swimos")),

client/runtime/src/runtime.rs

@@ -446,7 +446,7 @@ async fn runtime_task<Net, Ws, Provider>(
                 host,
                 result: Ok((addr, attach)),
             } => {
-                assert!(peers.get(&addr).is_none());
+                assert!(!peers.contains_key(&addr));
                 let peer = Peer::new(attach);
 
                 for (key, pending_downlink) in pending.drain_connection_queue(host.clone()) {

macro_utilities/src/label.rs

@@ -16,6 +16,7 @@ use core::fmt;
 use core::fmt::{Debug, Formatter};
 use proc_macro2::{Ident, TokenStream};
 use quote::ToTokens;
+use std::fmt::Display;
 use syn::Index;
 
 /// An enumeration representing a field or a compound type. This enumeration helps to keep track of
@@ -35,7 +36,7 @@ pub enum Label {
 
 impl Debug for Label {
     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
-        write!(f, "{}", self.to_string())
+        write!(f, "{}", self)
     }
 }
 
@@ -92,13 +93,13 @@ impl Label {
     }
 }
 
-impl ToString for Label {
-    fn to_string(&self) -> String {
+impl Display for Label {
+    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
         match self {
-            Label::Unmodified(ident) => ident.to_string(),
-            Label::Renamed { new_label, .. } => new_label.to_string(),
-            Label::Anonymous(index) => format!("__self_{}", index.index),
-            Label::Foreign(ident, ..) => ident.to_string(),
+            Label::Unmodified(ident) => write!(f, "{}", ident),
+            Label::Renamed { new_label, .. } => write!(f, "{}", new_label),
+            Label::Anonymous(index) => write!(f, "__self_{}", index.index),
+            Label::Foreign(ident, ..) => write!(f, "{}", ident),
         }
     }
 }

server/swimos_agent/src/agent_lifecycle/utility/mod.rs

@@ -325,7 +325,7 @@ impl<Agent: 'static> HandlerContext<Agent> {
     /// #Arguments
     /// * `lane` - Projection to the value lane.
     /// * `value` - The value of the command.
-    pub fn command<T: Send + 'static>(
+    pub fn command<T>(
         &self,
         lane: fn(&Agent) -> &CommandLane<T>,
         value: T,

swimos_utilities/byte_channel/src/coop/mod.rs

@@ -28,7 +28,7 @@ mod tests;
 const DEFAULT_START_BUDGET: NonZeroUsize = unsafe { NonZeroUsize::new_unchecked(64) };
 
 thread_local! {
-    static TASK_BUDGET: Cell<Option<usize>> = Cell::new(None);
+    static TASK_BUDGET: Cell<Option<usize>> = const { Cell::new(None) };
 }
 
 #[inline]

swimos_utilities/swimos_rtree/src/lib.rs

@@ -173,7 +173,7 @@ where
     /// assert_eq!(rtree.len(), 2);
     /// ```
     pub fn insert(&mut self, label: L, item: B) -> Result<(), DuplicateLabelError<L>> {
-        if self.lookup_map.get(&label).is_some() {
+        if self.lookup_map.contains_key(&label) {
             return Err(DuplicateLabelError(label));
         }
 
@@ -322,7 +322,7 @@ where
         let mut entries = Vec::new();
 
         for (label, item) in items.into_iter() {
-            if lookup_map.get(&label).is_some() {
+            if lookup_map.contains_key(&label) {
                 return Err(RTreeError::from(DuplicateLabelError(label)));
             }
 

swimos_utilities/swimos_trigger/src/lib.rs

@@ -123,7 +123,7 @@ impl Future for Receiver {
                     0 => {
                         if let Some(waker) = slot.and_then(|i| lock.get_mut(i)) {
                             if !waker.will_wake(cx.waker()) {
-                                *waker = cx.waker().clone();
+                                waker.clone_from(cx.waker());
                             }
                         } else {
                             *slot = Some(lock.insert(cx.waker().clone()));