Tidies up cryptographic provider error messaging

Author: SirCipher

runtime/swimos_remote/src/tls/errors.rs

@@ -32,6 +32,10 @@ pub enum TlsError {
     /// Performing the TLS handshake failed.
     #[error("TLS handshake failed: {0}")]
     HandshakeFailed(std::io::Error),
-    #[error("Invalid cryptographic provider configured: {0}")]
-    InvalidCryptoProvider(String),
+    /// User specified that a cryptographic provider had been installed but none was found.
+    #[error("No default cryptographic provider has been installed")]
+    NoCryptoProviderInstalled,
+    /// User specified more than one cryptographic provider feature flag. Only one may be specified.
+    #[error("Ambiguous cryptographic provider feature flags specified. Only \"ring_provider\" or \"aws_lc_rs_provider\" may be specified")]
+    InvalidCryptoProvider,
 }

runtime/swimos_remote/src/tls/mod.rs

@@ -38,11 +38,7 @@ impl CryptoProviderConfig {
     pub fn try_build(self) -> Result<Arc<CryptoProvider>, TlsError> {
         match self {
             CryptoProviderConfig::ProcessDefault => CryptoProvider::get_default()
-                .ok_or_else(|| {
-                    TlsError::InvalidCryptoProvider(
-                        "No default cryptographic provider specified".to_string(),
-                    )
-                })
+                .ok_or(TlsError::NoCryptoProviderInstalled)
                 .cloned(),
             CryptoProviderConfig::FromFeatureFlags => {
                 #[cfg(all(feature = "ring_provider", not(feature = "aws_lc_rs_provider")))]
@@ -57,7 +53,7 @@ impl CryptoProviderConfig {
 
                 #[allow(unreachable_code)]
                 {
-                    Err(TlsError::InvalidCryptoProvider("Ambiguous cryptographic provider feature flags specified. Only \"ring_provider\" or \"aws_lc_rs_provider\" may be specified".to_string()))
+                    Err(TlsError::InvalidCryptoProvider)
                 }
             }
             CryptoProviderConfig::Provided(provider) => Ok(provider),