Skip to content

Commit a0da3be

Browse files
committed
Replaced deprecated JedisShardInfo with RedisStandaloneConfiguration
1 parent e091fe9 commit a0da3be

File tree

4 files changed

+30
-16
lines changed

4 files changed

+30
-16
lines changed

src/docs/asciidoc/configuration.adoc

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ All configuration values are prefixed with `grails.cache.redis`
2929
|`integer`
3030
|Server port to connect to
3131

32+
|`username`
33+
|(not set)
34+
|`String`
35+
|Server username (only if required)
3236

3337
|`password`
3438
|(not set)
@@ -74,3 +78,12 @@ All configuration values are prefixed with `grails.cache.redis`
7478
|===
7579

7680
*Note:* There is currently no way of setting each cache configuration individually.
81+
82+
=== Advanced configuration
83+
84+
The standard configuration will use `org.springframework.data.redis.connection.RedisStandaloneConfiguration` and will connect to a single server. This configuration is instanticated as a the `grailsCacheRedisConfiguration` bean. If more advance configuration is needed, consider using `org.springframework.data.redis.connection.RedisClusterConfiguration` or `org.springframework.data.redis.connection.RedisSentinelConfiguration` instead.
85+
86+
This should be archiveable by adding:
87+
88+
----
89+
grailsCacheRedisConfiguration(RedisClusterConfiguration,)

src/docs/asciidoc/index.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ include::introduction/changeLog.adoc[]
1818

1919
include::usage.adoc[]
2020

21-
2221
[[configuration]]
2322
== Configuration
23+
2424
include::configuration.adoc[]
2525

2626
[[dsl]]
27-
=== Cache DSL
27+
== Cache DSL
2828

2929
include::usage/dsl.adoc[]
3030

src/docs/asciidoc/introduction/changeLog.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,6 @@
77
=== Version 6.0.0 - June 2, 2025
88

99
* Upgraded to Grails 6.2.x
10+
* Removed `JedisShardInfo` in plugin descriptor in favor of `RedisStandaloneConfiguration`
11+
* Updated documentation
1012

src/main/groovy/grails/plugin/cache/redis/CacheRedisGrailsPlugin.groovy

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ import grails.plugins.Plugin
66
import org.slf4j.Logger
77
import org.slf4j.LoggerFactory
88
import org.springframework.data.redis.cache.CacheKeyPrefix
9+
import org.springframework.data.redis.connection.RedisStandaloneConfiguration
910
import org.springframework.data.redis.connection.jedis.JedisConnectionFactory
1011
import org.springframework.data.redis.core.RedisTemplate
1112
import redis.clients.jedis.JedisPoolConfig
12-
import redis.clients.jedis.JedisShardInfo
1313
import redis.clients.jedis.Protocol
1414

1515
/**
@@ -62,29 +62,28 @@ class CacheRedisGrailsPlugin extends Plugin {
6262
String configHostName = config.getProperty('grails.cache.redis.hostName', 'localhost')
6363
int configPort = config.getProperty('grails.cache.redis.port', Integer, Protocol.DEFAULT_PORT)
6464
int configTimeout = config.getProperty('grails.cache.redis.timeout', Integer, Protocol.DEFAULT_TIMEOUT)
65+
String configUsername = config.getProperty('grails.cache.redis.username')
6566
String configPassword = config.getProperty('grails.cache.redis.password')
6667
Long ttlInSeconds = config.getProperty('grails.cache.redis.ttl', Long, GrailsRedisCache.NEVER_EXPIRE)
6768
boolean isUsePrefix = config.getProperty('grails.cache.redis.usePrefix', Boolean, false)
6869

6970
String keySerializerBean = config.getProperty('grails.cache.redis.keySerializer')
7071
String hashKeySerializerBean = config.getProperty('grails.cache.redis.hashKeySerializer')
7172

72-
grailsCacheJedisPoolConfig(JedisPoolConfig)
73+
grailsCacheRedisPoolConfig(JedisPoolConfig)
7374

74-
grailsCacheJedisShardInfo(JedisShardInfo, configHostName, configPort) {
75-
password = configPassword
76-
connectionTimeout = configTimeout
75+
grailsCacheRedisConfiguration(RedisStandaloneConfiguration, configHostName, configPort) {
76+
username = configUsername
77+
if(configPassword) {
78+
password = configPassword
79+
}
80+
database = configDatabase
7781
}
7882

79-
grailsCacheJedisConnectionFactory(JedisConnectionFactory) {
83+
grailsCacheJedisConnectionFactory(JedisConnectionFactory, ref('grailsCacheRedisConfiguration')) {
8084
usePool = configUsePool
81-
database = configDatabase
82-
hostName = configHostName
83-
port = configPort
8485
timeout = configTimeout
85-
password = configPassword
86-
poolConfig = ref('grailsCacheJedisPoolConfig')
87-
shardInfo = ref('grailsCacheJedisShardInfo')
86+
poolConfig = ref('grailsCacheRedisPoolConfig')
8887
}
8988

9089
grailsRedisCacheSerializer(GrailsSerializer)
@@ -118,10 +117,10 @@ class CacheRedisGrailsPlugin extends Plugin {
118117
String delimiter = config.getProperty('grails.cache.redis.cachePrefixDelimiter', CacheKeyPrefix.SEPARATOR)
119118
String prefix = config.getProperty('grails.cache.redis.cachePrefix', '')
120119

121-
redisCachePrefix(DelimiterCacheKeyPrefix, delimiter, prefix)
120+
grailsRedisCachePrefix(DelimiterCacheKeyPrefix, delimiter, prefix)
122121

123122
grailsCacheManager(GrailsRedisCacheManager, ref('grailsCacheRedisTemplate')) {
124-
cachePrefix = ref('redisCachePrefix', false)
123+
cachePrefix = ref('grailsRedisCachePrefix', false)
125124
timeToLive = ttlInSeconds
126125
usePrefix = isUsePrefix
127126
}

0 commit comments

Comments
 (0)