Revert "Add metrics emission test (#167)"

This reverts commit dac5c9a.

Page.WaitForLoadState() isn't enough to avoid flakiness[1], so reverting
this for now.

[1]: https://github.com/grafana/xk6-browser/runs/4608718007

Author: Ivan Mirić

tests/metrics_test.go

@@ -23,15 +23,10 @@ package tests
 import (
 	"testing"
 
-	"github.com/grafana/xk6-browser/common"
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	k6metrics "go.k6.io/k6/lib/metrics"
-	k6stats "go.k6.io/k6/stats"
 )
 
 func TestDataURLSkipRequest(t *testing.T) {
-	t.Parallel()
 	tb := newTestBrowser(t)
 	p := tb.NewPage(nil)
 
@@ -41,63 +36,3 @@ func TestDataURLSkipRequest(t *testing.T) {
 
 	assert.True(t, lc.contains("skipped request handling of data URL"))
 }
-
-func TestMetricsEmission(t *testing.T) {
-	t.Parallel()
-	tb := newTestBrowser(t, withHTTPServer())
-
-	url := tb.URL("/get")
-	browserTags := map[string]string{
-		"group": "",
-		"url":   "about:blank",
-	}
-	httpTags := map[string]string{
-		"method":              "GET",
-		"url":                 url,
-		"status":              "200",
-		"group":               "",
-		"proto":               "http/1.1",
-		"from_cache":          "false",
-		"from_prefetch_cache": "false",
-		"from_service_worker": "false",
-	}
-	expMetricTags := map[string]map[string]string{
-		common.BrowserDOMContentLoaded.Name: browserTags,
-		common.BrowserLoaded.Name:           browserTags,
-		k6metrics.DataSentName: map[string]string{
-			"group":  "",
-			"method": "GET",
-			"url":    url,
-		},
-		k6metrics.HTTPReqsName:              httpTags,
-		k6metrics.HTTPReqDurationName:       httpTags,
-		k6metrics.DataReceivedName:          httpTags,
-		k6metrics.HTTPReqConnectingName:     httpTags,
-		k6metrics.HTTPReqTLSHandshakingName: httpTags,
-		k6metrics.HTTPReqSendingName:        httpTags,
-		k6metrics.HTTPReqReceivingName:      httpTags,
-	}
-
-	p := tb.NewPage(nil)
-	resp := p.Goto(url, nil)
-	require.NotNil(t, resp)
-
-	// Wait for all metrics to be emitted
-	p.WaitForLoadState("networkidle", nil)
-
-	bufSamples := k6stats.GetBufferedSamples(tb.samples)
-
-	var reqsCount int
-	cb := func(sample k6stats.Sample) {
-		switch sample.Metric.Name {
-		case k6metrics.HTTPReqsName:
-			reqsCount += int(sample.Value)
-		case k6metrics.DataSentName, k6metrics.DataReceivedName:
-			assert.Greaterf(t, int(sample.Value), 0,
-				"metric %s", sample.Metric.Name)
-		}
-	}
-
-	assertMetricsEmitted(t, bufSamples, expMetricTags, cb)
-	assert.Equal(t, 1, reqsCount)
-}