Refactor set navigation timeout with duration

time.Duration should be used throughout the codebase instead of int64.
This change ensures that in64 is quickly converted to a time.Duration
which means we have to care less about whether the in64 is in seconds
or milliseconds etc.

Author: ankur22

common/browser_context.go

@@ -265,7 +265,7 @@ func (b *BrowserContext) Route(url goja.Value, handler goja.Callable) {
 func (b *BrowserContext) SetDefaultNavigationTimeout(timeout int64) {
 	b.logger.Debugf("BrowserContext:SetDefaultNavigationTimeout", "bctxid:%v timeout:%d", b.id, timeout)
 
-	b.timeoutSettings.setDefaultNavigationTimeout(timeout)
+	b.timeoutSettings.setDefaultNavigationTimeout(time.Duration(timeout) * time.Millisecond)
 }
 
 // SetDefaultTimeout sets the default maximum timeout in milliseconds.

common/page.go

@@ -968,7 +968,7 @@ func (p *Page) SetContent(html string, opts goja.Value) {
 func (p *Page) SetDefaultNavigationTimeout(timeout int64) {
 	p.logger.Debugf("Page:SetDefaultNavigationTimeout", "sid:%v timeout:%d", p.sessionID(), timeout)
 
-	p.timeoutSettings.setDefaultNavigationTimeout(timeout)
+	p.timeoutSettings.setDefaultNavigationTimeout(time.Duration(timeout) * time.Millisecond)
 }
 
 // SetDefaultTimeout sets the default maximum timeout in milliseconds.

common/timeout.go

@@ -23,9 +23,8 @@ func (t *TimeoutSettings) setDefaultTimeout(timeout int64) {
 	t.defaultTimeout = &timeout
 }
 
-func (t *TimeoutSettings) setDefaultNavigationTimeout(timeout int64) {
-	d := time.Duration(timeout) * time.Millisecond
-	t.defaultNavigationTimeout = &d
+func (t *TimeoutSettings) setDefaultNavigationTimeout(timeout time.Duration) {
+	t.defaultNavigationTimeout = &timeout
 }
 
 func (t *TimeoutSettings) navigationTimeout() time.Duration {

common/timeout_test.go

@@ -2,6 +2,7 @@ package common
 
 import (
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 )
@@ -70,7 +71,7 @@ func testTimeoutSettingsSetDefaultNavigationTimeout(t *testing.T) {
 	t.Parallel()
 
 	ts := NewTimeoutSettings(nil)
-	ts.setDefaultNavigationTimeout(100)
+	ts.setDefaultNavigationTimeout(time.Duration(100) * time.Millisecond)
 	assert.Equal(t, int64(100), ts.defaultNavigationTimeout.Milliseconds())
 }
 
@@ -83,7 +84,7 @@ func testTimeoutSettingsNavigationTimeout(t *testing.T) {
 	assert.Equal(t, DefaultTimeout, ts.navigationTimeout())
 
 	// Assert custom default timeout is used
-	ts.setDefaultNavigationTimeout(100)
+	ts.setDefaultNavigationTimeout(time.Duration(100) * time.Millisecond)
 	assert.Equal(t, int64(100), ts.navigationTimeout().Milliseconds())
 }
 
@@ -97,11 +98,11 @@ func testTimeoutSettingsNavigationTimeoutWithParent(t *testing.T) {
 	assert.Equal(t, DefaultTimeout, tsWithParent.navigationTimeout())
 
 	// Assert custom default timeout from parent is used
-	ts.setDefaultNavigationTimeout(1000)
+	ts.setDefaultNavigationTimeout(time.Duration(1000) * time.Millisecond)
 	assert.Equal(t, int64(1000), tsWithParent.navigationTimeout().Milliseconds())
 
 	// Assert custom default timeout is used (over parent)
-	tsWithParent.setDefaultNavigationTimeout(100)
+	tsWithParent.setDefaultNavigationTimeout(time.Duration(100) * time.Millisecond)
 	assert.Equal(t, int64(100), tsWithParent.navigationTimeout().Milliseconds())
 }