Remove emitting of lifecycle events

These internal lifecycle events aren't being listened to by any
handler. Let's remove it for now and add it back in when there is a
need for them.

Author: ankur22

common/event_emitter.go

@@ -29,25 +29,23 @@ const (
 
 	// Page
 
-	EventPageClose            string = "close"
-	EventPageConsole          string = "console"
-	EventPageCrash            string = "crash"
-	EventPageDialog           string = "dialog"
-	EventPageDOMContentLoaded string = "domcontentloaded"
-	EventPageDownload         string = "download"
-	EventPageFilechooser      string = "filechooser"
-	EventPageFrameAttached    string = "frameattached"
-	EventPageFrameDetached    string = "framedetached"
-	EventPageFrameNavigated   string = "framenavigated"
-	EventPageLoad             string = "load"
-	EventPageError            string = "pageerror"
-	EventPagePopup            string = "popup"
-	EventPageRequest          string = "request"
-	EventPageRequestFailed    string = "requestfailed"
-	EventPageRequestFinished  string = "requestfinished"
-	EventPageResponse         string = "response"
-	EventPageWebSocket        string = "websocket"
-	EventPageWorker           string = "worker"
+	EventPageClose           string = "close"
+	EventPageConsole         string = "console"
+	EventPageCrash           string = "crash"
+	EventPageDialog          string = "dialog"
+	EventPageDownload        string = "download"
+	EventPageFilechooser     string = "filechooser"
+	EventPageFrameAttached   string = "frameattached"
+	EventPageFrameDetached   string = "framedetached"
+	EventPageFrameNavigated  string = "framenavigated"
+	EventPageError           string = "pageerror"
+	EventPagePopup           string = "popup"
+	EventPageRequest         string = "request"
+	EventPageRequestFailed   string = "requestfailed"
+	EventPageRequestFinished string = "requestfinished"
+	EventPageResponse        string = "response"
+	EventPageWebSocket       string = "websocket"
+	EventPageWorker          string = "worker"
 
 	// Session
 

common/frame.go

@@ -219,22 +219,11 @@ func (f *Frame) recalculateLifecycle() {
 	f.childFramesMu.RUnlock()
 
 	// Check if any of the fired events should be considered fired when looking at the entire subtree.
-	mainFrame := f.manager.MainFrame()
 	for k := range events {
 		if f.hasSubtreeLifecycleEventFired(k) {
 			continue
 		}
 		f.emit(EventFrameAddLifecycle, k)
-
-		if f != mainFrame {
-			continue
-		}
-		switch k {
-		case LifecycleEventLoad:
-			f.page.emit(EventPageLoad, nil)
-		case LifecycleEventDOMContentLoad:
-			f.page.emit(EventPageDOMContentLoaded, nil)
-		}
 	}
 
 	f.lifecycleEventsMu.Lock()