Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Commit d183dfa

Browse files
committed
Remove the emitting of the remove lifecycle event
There's nothing listening to these events. We can add it back in when there is need for it, but at the moment it's just dead code.
1 parent b2011d0 commit d183dfa

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

common/event_emitter.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@ const (
2424

2525
// Frame
2626

27-
EventFrameNavigation string = "navigation"
28-
EventFrameAddLifecycle string = "addlifecycle"
29-
EventFrameRemoveLifecycle string = "removelifecycle"
27+
EventFrameNavigation string = "navigation"
28+
EventFrameAddLifecycle string = "addlifecycle"
3029

3130
// Page
3231

common/frame.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -238,17 +238,6 @@ func (f *Frame) recalculateLifecycle() {
238238
}
239239
}
240240

241-
// Emit removal events
242-
f.lifecycleEventsMu.RLock()
243-
{
244-
for k := range f.subtreeLifecycleEvents {
245-
if ok := events[k]; !ok {
246-
f.emit(EventFrameRemoveLifecycle, k)
247-
}
248-
}
249-
}
250-
f.lifecycleEventsMu.RUnlock()
251-
252241
f.lifecycleEventsMu.Lock()
253242
{
254243
f.subtreeLifecycleEvents = make(map[LifecycleEvent]bool)

0 commit comments

Comments
 (0)