Add a new EvaluateWithContext

This new EvaluateWithContext will allow us to pass in a context with a
timeout. For issue #971, we're seeing that often the evaluate to hide
the page on page.close ends up in a deadlock (waiting for the response
from the chrome browser after executing the CDP evaluate command). We
are not sure of the root cause of the issue, but this fix will help
prevent this deadlock allow the test run to complete in a timely
manner without it causing a time out error.

Author: ankur22

api/frame.go

@@ -1,6 +1,10 @@
 package api
 
-import "github.com/dop251/goja"
+import (
+	"context"
+
+	"github.com/dop251/goja"
+)
 
 // Frame is the interface of a CDP target frame.
 type Frame interface {
@@ -12,6 +16,8 @@ type Frame interface {
 	Content() string
 	Dblclick(selector string, opts goja.Value)
 	DispatchEvent(selector string, typ string, eventInit goja.Value, opts goja.Value)
+	// EvaluateWithContext for internal use only
+	EvaluateWithContext(ctx context.Context, pageFunc goja.Value, args ...goja.Value) (any, error)
 	Evaluate(pageFunc goja.Value, args ...goja.Value) any
 	EvaluateHandle(pageFunc goja.Value, args ...goja.Value) (JSHandle, error)
 	Fill(selector string, value string, opts goja.Value)

browser/mapping_test.go

@@ -35,11 +35,12 @@ func customMappings() map[string]string {
 		"Page.getMouse":       "mouse",
 		"Page.getTouchscreen": "touchscreen",
 		// internal methods
-		"ElementHandle.objectID": "",
-		"Frame.id":               "",
-		"Frame.loaderID":         "",
-		"JSHandle.objectID":      "",
-		"Browser.close":          "",
+		"ElementHandle.objectID":    "",
+		"Frame.id":                  "",
+		"Frame.loaderID":            "",
+		"JSHandle.objectID":         "",
+		"Browser.close":             "",
+		"Frame.evaluateWithContext": "",
 		// TODO: browser.on method is unexposed until more event
 		// types other than 'disconnect' are supported.
 		// See: https://github.com/grafana/xk6-browser/issues/913

common/frame.go

@@ -709,6 +709,28 @@ func (f *Frame) dispatchEvent(selector, typ string, eventInit goja.Value, opts *
 	return nil
 }
 
+// EvaluateWithContext will evaluate provided page function within an execution context.
+// The passed in context will be used instead of the frame's context. The context must
+// be a derivative of one that contains the goja runtime.
+func (f *Frame) EvaluateWithContext(ctx context.Context, pageFunc goja.Value, args ...goja.Value) (any, error) {
+	f.log.Debugf("Frame:EvaluateWithContext", "fid:%s furl:%q", f.ID(), f.URL())
+
+	f.waitForExecutionContext(mainWorld)
+
+	opts := evalOptions{
+		forceCallable: true,
+		returnByValue: true,
+	}
+	result, err := f.evaluate(ctx, mainWorld, opts, pageFunc, args...)
+	if err != nil {
+		return nil, fmt.Errorf("evaluating JS: %w", err)
+	}
+
+	applySlowMo(ctx)
+
+	return result, nil
+}
+
 // Evaluate will evaluate provided page function within an execution context.
 func (f *Frame) Evaluate(pageFunc goja.Value, args ...goja.Value) any {
 	f.log.Debugf("Frame:Evaluate", "fid:%s furl:%q", f.ID(), f.URL())