Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Commit b63341b

Browse files
committed
Refactor to use getFrameByID
1 parent 3cee653 commit b63341b

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

common/frame_manager.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,8 @@ func (m *FrameManager) frameAttached(frameID cdp.FrameID, parentFrameID cdp.Fram
169169
func (m *FrameManager) frameDetached(frameID cdp.FrameID) {
170170
m.logger.Debugf("FrameManager:frameDetached", "fmid:%d fid:%v", m.ID(), frameID)
171171

172-
// TODO: use getFrameByID here
173-
m.framesMu.RLock()
174-
frame, ok := m.frames[frameID]
175-
m.framesMu.RUnlock()
176-
if !ok {
172+
frame := m.getFrameByID(frameID)
173+
if frame == nil {
177174
m.logger.Debugf("FrameManager:frameDetached:return",
178175
"fmid:%d fid:%v cannot find frame",
179176
m.ID(), frameID)

0 commit comments

Comments
 (0)