Remove neworkidle timer as its not needed

This timer is no longer needed since the fixes in PR #555 and #597.
These PRs helped to ensure that we receive the CDP events in order
and that we correctly handle them when we do receive them. The
networkidle timer was in place for a situation where we might not
receive the networkidle lifecycle event from the browser via CDP.
This could still occur, which would mean that there's a bug outside
of our direct control. When this happens we should find a better
solution.

Author: ankur22

common/frame.go

@@ -65,8 +65,6 @@ type Frame struct {
 
 	loadingStartedTime time.Time
 
-	networkIdleCh chan struct{}
-
 	inflightRequestsMu sync.RWMutex
 	inflightRequests   map[network.RequestID]bool
 
@@ -107,7 +105,6 @@ func NewFrame(
 		inflightRequests:       make(map[network.RequestID]bool),
 		executionContexts:      make(map[executionWorld]frameExecutionContext),
 		currentDocument:        &DocumentInfo{},
-		networkIdleCh:          make(chan struct{}),
 		log:                    log,
 	}
 }
@@ -188,11 +185,6 @@ func (f *Frame) clearLifecycle() {
 		f.inflightRequests = inflightRequests
 	}
 	f.inflightRequestsMu.Unlock()
-
-	f.stopNetworkIdleTimer()
-	if f.inflightRequestsLen() == 0 {
-		f.startNetworkIdleTimer()
-	}
 }
 
 func (f *Frame) recalculateLifecycle() {
@@ -267,38 +259,9 @@ func (f *Frame) recalculateLifecycle() {
 	f.lifecycleEventsMu.Unlock()
 }
 
-func (f *Frame) stopNetworkIdleTimer() {
-	f.log.Debugf("Frame:stopNetworkIdleTimer", "fid:%s furl:%q", f.ID(), f.URL())
-
-	select {
-	case f.networkIdleCh <- struct{}{}:
-	default:
-	}
-}
-
-func (f *Frame) startNetworkIdleTimer() {
-	f.log.Debugf("Frame:startNetworkIdleTimer", "fid:%s furl:%q", f.ID(), f.URL())
-
-	if f.hasLifecycleEventFired(LifecycleEventNetworkIdle) || f.IsDetached() {
-		return
-	}
-
-	f.stopNetworkIdleTimer()
-
-	go func() {
-		select {
-		case <-f.ctx.Done():
-		case <-f.networkIdleCh:
-		case <-time.After(LifeCycleNetworkIdleTimeout):
-			f.manager.frameLifecycleEvent(cdp.FrameID(f.ID()), LifecycleEventNetworkIdle)
-		}
-	}()
-}
-
 func (f *Frame) detach() {
 	f.log.Debugf("Frame:detach", "fid:%s furl:%q", f.ID(), f.URL())
 
-	f.stopNetworkIdleTimer()
 	f.setDetached(true)
 	if f.parentFrame != nil {
 		f.parentFrame.removeChildFrame(f)

common/frame_manager.go

@@ -100,12 +100,6 @@ func (m *FrameManager) removeBarrier(b *Barrier) {
 
 func (m *FrameManager) dispose() {
 	m.logger.Debugf("FrameManager:dispose", "fmid:%d", m.ID())
-
-	m.framesMu.RLock()
-	defer m.framesMu.RUnlock()
-	for _, f := range m.frames {
-		f.stopNetworkIdleTimer()
-	}
 }
 
 func (m *FrameManager) frameAbortedNavigation(frameID cdp.FrameID, errorText, documentID string) {
@@ -452,8 +446,6 @@ func (m *FrameManager) requestFailed(req *Request, canceled bool) {
 
 	ifr := frame.cloneInflightRequests()
 	switch rc := len(ifr); {
-	case rc == 0:
-		frame.startNetworkIdleTimer()
 	case rc <= 10:
 		for reqID := range ifr {
 			req := frame.requestByID(reqID)
@@ -503,9 +495,6 @@ func (m *FrameManager) requestFinished(req *Request) {
 		return
 	}
 	frame.deleteRequest(req.getID())
-	if frame.inflightRequestsLen() == 0 {
-		frame.startNetworkIdleTimer()
-	}
 	/*
 		else if frame.inflightRequestsLen() <= 10 {
 			for reqID, _ := range frame.inflightRequests {
@@ -537,9 +526,6 @@ func (m *FrameManager) requestStarted(req *Request) {
 	}
 
 	frame.addRequest(req.getID())
-	if frame.inflightRequestsLen() == 1 {
-		frame.stopNetworkIdleTimer()
-	}
 	if req.documentID != "" {
 		frame.pendingDocumentMu.Lock()
 		frame.pendingDocument = &DocumentInfo{documentID: req.documentID, request: req}