Fix press in classes to work with combo keys (#522)

* Fix press in classes to work with combo keys

ElementHandle, Page, Locator and Frame all have the Press method. In a
recent fix (#326) combo keys with the Shift modifier key was fixed for
the Keyboard Press method. The Press methods for the other classes
should have worked with combo ley presses, but didn't. This fix will
ensure that combo key presses work for all of them.

Closes: #521

* Apply suggestions from code review

Co-authored-by: Ivan Mirić <ivan.miric@grafana.com>

Co-authored-by: Ivan Mirić <ivan.miric@grafana.com>

Author: ankur22

common/element_handle.go

@@ -476,7 +476,7 @@ func (h *ElementHandle) press(apiCtx context.Context, key string, opts *Keyboard
 	if err != nil {
 		return err
 	}
-	err = h.frame.page.Keyboard.press(key, opts)
+	err = h.frame.page.Keyboard.comboPress(key, opts)
 	if err != nil {
 		return err
 	}

tests/element_handle_test.go

@@ -359,3 +359,19 @@ func TestElementHandleWaitForSelector(t *testing.T) {
 
 	element.Dispose()
 }
+
+func TestElementHandlePress(t *testing.T) {
+	tb := newTestBrowser(t)
+
+	p := tb.NewPage(nil)
+
+	p.SetContent(`<input>`, nil)
+
+	el := p.Query("input")
+
+	el.Press("Shift+KeyA", nil)
+	el.Press("KeyB", nil)
+	el.Press("Shift+KeyC", nil)
+
+	require.Equal(t, "AbC", el.InputValue(nil))
+}

tests/frame_test.go

@@ -0,0 +1,23 @@
+package tests
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestFramePress(t *testing.T) {
+	tb := newTestBrowser(t)
+
+	p := tb.NewPage(nil)
+
+	p.SetContent(`<input id="text1">`, nil)
+
+	f := p.Frames()[0]
+
+	f.Press("#text1", "Shift+KeyA", nil)
+	f.Press("#text1", "KeyB", nil)
+	f.Press("#text1", "Shift+KeyC", nil)
+
+	require.Equal(t, "AbC", f.InputValue("#text1", nil))
+}

tests/locator_test.go

@@ -370,3 +370,19 @@ func TestLocatorElementState(t *testing.T) {
 		})
 	}
 }
+
+func TestLocatorPress(t *testing.T) {
+	tb := newTestBrowser(t)
+
+	p := tb.NewPage(nil)
+
+	p.SetContent(`<input id="text1">`, nil)
+
+	l := p.Locator("#text1", nil)
+
+	l.Press("Shift+KeyA", nil)
+	l.Press("KeyB", nil)
+	l.Press("Shift+KeyC", nil)
+
+	require.Equal(t, "AbC", l.InputValue(nil))
+}

tests/page_test.go

@@ -684,6 +684,20 @@ func TestPageWaitForNavigationShouldNotPanic(t *testing.T) {
 	require.NotPanics(t, func() { p.WaitForNavigation(nil) })
 }
 
+func TestPagePress(t *testing.T) {
+	tb := newTestBrowser(t)
+
+	p := tb.NewPage(nil)
+
+	p.SetContent(`<input id="text1">`, nil)
+
+	p.Press("#text1", "Shift+KeyA", nil)
+	p.Press("#text1", "KeyB", nil)
+	p.Press("#text1", "Shift+KeyC", nil)
+
+	require.Equal(t, "AbC", p.InputValue("#text1", nil))
+}
+
 func assertPanicErrorContains(t *testing.T, err interface{}, expErrMsg string) {
 	t.Helper()