Fix defaulting to load in WaitForLoadState

Ivan Mirić · Ivan Mirić · commit a526dd99914f · 2022-04-26T10:17:57.000+02:00
diff --git a/common/frame.go b/common/frame.go
@@ -1583,9 +1583,11 @@ func (f *Frame) WaitForLoadState(state string, opts goja.Value) {
 		k6Throw(f.ctx, "cannot parse waitForLoadState options: %v", err)
 	}
 
-	var waitUntil LifecycleEvent
-	if err = waitUntil.UnmarshalText([]byte(state)); err != nil {
-		k6Throw(f.ctx, "waitForLoadState error: %v", err)
+	waitUntil := LifecycleEventLoad
+	if state != "" {
+		if err = waitUntil.UnmarshalText([]byte(state)); err != nil {
+			k6Throw(f.ctx, "waitForLoadState error: %v", err)
+		}
 	}
 
 	if f.hasLifecycleEventFired(waitUntil) {

Original file line number	Diff line number	Diff line change
`@@ -1583,9 +1583,11 @@ func (f *Frame) WaitForLoadState(state string, opts goja.Value) {`
`1583`	`1583`	`k6Throw(f.ctx, "cannot parse waitForLoadState options: %v", err)`
`1584`	`1584`	`}`
`1585`	`1585`
`1586`		`- var waitUntil LifecycleEvent`
`1587`		`- if err = waitUntil.UnmarshalText([]byte(state)); err != nil {`
`1588`		`- k6Throw(f.ctx, "waitForLoadState error: %v", err)`
	`1586`	`+ waitUntil := LifecycleEventLoad`
	`1587`	`+ if state != "" {`
	`1588`	`+ if err = waitUntil.UnmarshalText([]byte(state)); err != nil {`
	`1589`	`+ k6Throw(f.ctx, "waitForLoadState error: %v", err)`
	`1590`	`+ }`
`1589`	`1591`	`}`
`1590`	`1592`
`1591`	`1593`	`if f.hasLifecycleEventFired(waitUntil) {`