Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Commit a3aea00

Browse files
committed
Fix pendingDocument log err in FrameManager
This log is faulty because sometimes pendingDocument is nil. I don't think adding an extra check in the log will help us. I added it before for convenience.
1 parent f074351 commit a3aea00

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

common/frame_manager.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -457,9 +457,7 @@ func (m *FrameManager) requestFailed(req *Request, canceled bool) {
457457
}
458458

459459
if frame.pendingDocument == nil || frame.pendingDocument.request != req {
460-
m.logger.Debugf("FrameManager:requestFailed:return",
461-
"fmid:%d pdoc:nil pdoc.req!=req:%t",
462-
m.ID(), frame.pendingDocument.request != req)
460+
m.logger.Debugf("FrameManager:requestFailed:return", "fmid:%d pdoc:nil", m.ID())
463461
return
464462
}
465463
errorText := req.errorText

0 commit comments

Comments
 (0)