Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Commit a1f1f6a

Browse files
committed
Refactor browser launch default options tests
1 parent e2a9d28 commit a1f1f6a

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

common/browser_options_test.go

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,13 @@ import (
1414
func TestBrowserLaunchOptionsParse(t *testing.T) {
1515
t.Parallel()
1616

17+
defaultOptions := &LaunchOptions{
18+
Env: make(map[string]string),
19+
Headless: true,
20+
LogCategoryFilter: ".*",
21+
Timeout: DefaultTimeout,
22+
}
23+
1724
for name, tt := range map[string]struct {
1825
opts map[string]any
1926
assert func(testing.TB, *LaunchOptions)
@@ -24,24 +31,14 @@ func TestBrowserLaunchOptionsParse(t *testing.T) {
2431
opts: map[string]any{},
2532
assert: func(tb testing.TB, lo *LaunchOptions) {
2633
tb.Helper()
27-
assert.Equal(t, &LaunchOptions{
28-
Env: make(map[string]string),
29-
Headless: true,
30-
LogCategoryFilter: ".*",
31-
Timeout: DefaultTimeout,
32-
}, lo)
34+
assert.Equal(t, defaultOptions, lo)
3335
},
3436
},
3537
"defaults_nil": { // providing nil option returns default options
3638
opts: nil,
3739
assert: func(tb testing.TB, lo *LaunchOptions) {
3840
tb.Helper()
39-
assert.Equal(t, &LaunchOptions{
40-
Env: make(map[string]string),
41-
Headless: true,
42-
LogCategoryFilter: ".*",
43-
Timeout: DefaultTimeout,
44-
}, lo)
41+
assert.Equal(t, defaultOptions, lo)
4542
},
4643
},
4744
"defaults_on_cloud": {

0 commit comments

Comments
 (0)