Refactor the tests to assert a change

ankur22 · ankur22 · commit 94271d2e3fb7 · 2022-11-29T13:18:47.000Z
Instead of always checking that the text field is Hello World, when
a dialog box opens, it will change the textField to reflect which
type of dialog appeared.
diff --git a/tests/frame_test.go b/tests/frame_test.go
@@ -56,8 +56,8 @@ func TestFrameDismissDialogBox(t *testing.T) {
 					WaitUntil: "networkidle",
 				})
 				b.promise(p.Goto(b.staticURL("dialog.html?dialogType="+tt.name), opts)).then(func() {
-					result := p.TextContent("#text", nil)
-					assert.EqualValues(t, "Hello World", result)
+					result := p.TextContent("#textField", nil)
+					assert.EqualValues(t, tt.name+" dismissed", result)
 				})
 
 				return nil
diff --git a/tests/static/dialog.html b/tests/static/dialog.html
@@ -1,22 +1,30 @@
 <html lang="en">
-    <head>
+    <head></head>
+    <body>
+        <div id='textField'>Hello World</div>
+        <br />
+        <a href="/">click here</a>
+
         <script>
             const queryString = window.location.search;
             const urlParams = new URLSearchParams(queryString);
-            const dialogType = urlParams.get('dialogType')
+            const dialogType = urlParams.get('dialogType');
+            const div = document.getElementById('textField');
 
             switch(dialogType) {
                 case "alert":
                     alert("Click accept");
+                    div.textContent = 'alert dismissed';
                     break;
                 case "confirm":
-                    confirm("Click accept")
+                    confirm("Click accept");
+                    div.textContent = 'confirm dismissed';
+                    break;
                 case "prompt":
-                    prompt("Add text and then click accept")
+                    prompt("Add text and then click accept");
+                    div.textContent = 'prompt dismissed';
+                    break;
             }
         </script>
-    </head>
-    <body>
-        <div id='text'>Hello World</div>
     </body>
 </html>
