Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Commit 90d971a

Browse files
committed
Add logs to FrameManager
1 parent 5398ca3 commit 90d971a

File tree

4 files changed

+232
-78
lines changed

4 files changed

+232
-78
lines changed

common/barrier_test.go

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,20 +29,18 @@ import (
2929
)
3030

3131
func TestBarrier(t *testing.T) {
32-
t.Run("should work", func(t *testing.T) {
33-
ctx := context.Background()
32+
ctx := context.Background()
3433

35-
log := NewLogger(ctx, NullLogger(), false, nil)
34+
log := NewLogger(ctx, NullLogger(), false, nil)
3635

37-
timeoutSetings := NewTimeoutSettings(nil)
38-
frameManager := NewFrameManager(ctx, nil, nil, timeoutSetings, log)
39-
frame := NewFrame(ctx, frameManager, nil, cdp.FrameID("frame_id_0123456789"), log)
36+
timeoutSetings := NewTimeoutSettings(nil)
37+
frameManager := NewFrameManager(ctx, nil, nil, timeoutSetings, log)
38+
frame := NewFrame(ctx, frameManager, nil, cdp.FrameID("frame_id_0123456789"), log)
4039

41-
barrier := NewBarrier()
42-
barrier.AddFrameNavigation(frame)
43-
frame.emit(EventFrameNavigation, "some data")
40+
barrier := NewBarrier()
41+
barrier.AddFrameNavigation(frame)
42+
frame.emit(EventFrameNavigation, "some data")
4443

45-
err := barrier.Wait(ctx)
46-
require.Nil(t, err)
47-
})
44+
err := barrier.Wait(ctx)
45+
require.Nil(t, err)
4846
}

0 commit comments

Comments
 (0)