Refactor emit to onLifecycleEvent

There's no need for recalculateLifecycle since all it is now doing is
emitting the event to internal handlers. So refactor/move it to
onLifecycleEvent.

Closes: #593

Author: ankur22

common/frame.go

@@ -183,12 +183,6 @@ func (f *Frame) clearLifecycle() {
 	f.inflightRequestsMu.Unlock()
 }
 
-func (f *Frame) recalculateLifecycle(event LifecycleEvent) {
-	f.log.Debugf("Frame:recalculateLifecycle", "fid:%s furl:%q", f.ID(), f.URL())
-
-	f.emit(EventFrameAddLifecycle, event)
-}
-
 func (f *Frame) detach() {
 	f.log.Debugf("Frame:detach", "fid:%s furl:%q", f.ID(), f.URL())
 
@@ -340,12 +334,10 @@ func (f *Frame) onLifecycleEvent(event LifecycleEvent) {
 	f.log.Debugf("Frame:onLifecycleEvent", "fid:%s furl:%q event:%s", f.ID(), f.URL(), event)
 
 	f.lifecycleEventsMu.Lock()
-	defer f.lifecycleEventsMu.Unlock()
-
-	if ok := f.lifecycleEvents[event]; ok {
-		return
-	}
 	f.lifecycleEvents[event] = true
+	f.lifecycleEventsMu.Unlock()
+
+	f.emit(EventFrameAddLifecycle, event)
 }
 
 func (f *Frame) onLoadingStarted() {

common/frame_manager.go

@@ -195,7 +195,6 @@ func (m *FrameManager) frameLifecycleEvent(frameID cdp.FrameID, event LifecycleE
 	frame := m.getFrameByID(frameID)
 	if frame != nil {
 		frame.onLifecycleEvent(event)
-		frame.recalculateLifecycle(event)
 	}
 }