Fix Page.InnerText()

This would previously panic with `interface conversion: interface {} is goja.asciiString, not string`

Author: Ivan Mirić

common/frame.go

@@ -1009,6 +1009,7 @@ func (f *Frame) InnerHTML(selector string, opts goja.Value) string {
 	return val.ToString().String()
 }
 
+// InnerText returns the innerText attribute of the element located by selector.
 func (f *Frame) InnerText(selector string, opts goja.Value) string {
 	f.log.Debugf("Frame:InnerText", "fid:%s furl:%q sel:%q", f.ID(), f.URL(), selector)
 
@@ -1029,7 +1030,17 @@ func (f *Frame) InnerText(selector string, opts goja.Value) string {
 	}
 
 	applySlowMo(f.ctx)
-	return value.(string)
+
+	if value == nil {
+		return ""
+	}
+
+	val, ok := value.(goja.Value)
+	if !ok {
+		k6Throw(f.ctx, "unexpected innerText value type: %T", value)
+	}
+
+	return val.ToString().String()
 }
 
 func (f *Frame) InputValue(selector string, opts goja.Value) string {

tests/page_test.go

@@ -214,6 +214,41 @@ func TestPageInnerHTML(t *testing.T) {
 	})
 }
 
+func TestPageInnerText(t *testing.T) {
+	t.Parallel()
+
+	t.Run("ok", func(t *testing.T) {
+		t.Parallel()
+
+		p := newTestBrowser(t).NewPage(nil)
+		p.SetContent(sampleHTML, nil)
+		assert.Equal(t, "Test\nOne", p.InnerText("div", nil))
+	})
+
+	t.Run("err_empty_selector", func(t *testing.T) {
+		t.Parallel()
+
+		defer func() {
+			assertPanicErrorContains(t, recover(), "The provided selector is empty")
+		}()
+
+		p := newTestBrowser(t).NewPage(nil)
+		p.InnerText("", nil)
+		t.Error("did not panic")
+	})
+
+	t.Run("err_wrong_selector", func(t *testing.T) {
+		t.Parallel()
+
+		tb := newTestBrowser(t)
+		p := tb.NewPage(nil)
+		p.SetContent(sampleHTML, nil)
+		assert.Equal(t, "", p.InnerText("p", tb.rt.ToValue(jsFrameBaseOpts{
+			Timeout: "100",
+		})))
+	})
+}
+
 func TestPageInputValue(t *testing.T) {
 	p := newTestBrowser(t).NewPage(nil)