Refactor to allow for more error handling

ankur22 · ankur22 · commit 51a2f1e2cc42 · 2024-04-30T14:35:50.000+01:00
diff --git a/common/js_handle.go b/common/js_handle.go
@@ -84,9 +84,12 @@ func (h *BaseJSHandle) Dispose() {
 		// context. The reason the context would be closed is due to the
 		// iteration ending and therefore the associated browser and its assets
 		// will be automatically deleted.
-		if !errors.Is(err, context.Canceled) {
-			k6ext.Panic(h.ctx, "dispose: %w", err)
+		if errors.Is(err, context.Canceled) {
+			h.logger.Debugf("BaseJSHandle:Dispose", "%v", err)
+			return
 		}
+
+		k6ext.Panic(h.ctx, "dispose: %w", err)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,12 @@ func (h *BaseJSHandle) Dispose() {`
`84`	`84`	`// context. The reason the context would be closed is due to the`
`85`	`85`	`// iteration ending and therefore the associated browser and its assets`
`86`	`86`	`// will be automatically deleted.`
`87`		`- if !errors.Is(err, context.Canceled) {`
`88`		`- k6ext.Panic(h.ctx, "dispose: %w", err)`
	`87`	`+ if errors.Is(err, context.Canceled) {`
	`88`	`+ h.logger.Debugf("BaseJSHandle:Dispose", "%v", err)`
	`89`	`+ return`
`89`	`90`	`}`
	`91`	`+`
	`92`	`+ k6ext.Panic(h.ctx, "dispose: %w", err)`
`90`	`93`	`}`
`91`	`94`	`}`
`92`	`95`