Remove unnecessary return value in keyboard layout

Author: inancgumus

common/keyboard.go

@@ -189,7 +189,7 @@ func (k *Keyboard) keyDefinitionFromKey(key keyboardlayout.KeyInput) keyboardlay
 	}
 	// Try to find with the shift key value
 	if !ok {
-		key, srcKeyDef = k.layout.ShiftKeyDefinition(key)
+		srcKeyDef = k.layout.ShiftKeyDefinition(key)
 		shift = k.modifiers | ModifierKeyShift
 	}
 

keyboardlayout/common.go

@@ -56,13 +56,13 @@ func (kl KeyboardLayout) KeyDefinition(key KeyInput) (KeyDefinition, bool) {
 
 // ShiftKeyDefinition returns shift key definition of a given key input.
 // It an empty key definition if it cannot find the key.
-func (kl KeyboardLayout) ShiftKeyDefinition(key KeyInput) (KeyInput, KeyDefinition) {
-	for k, d := range kl.Keys {
+func (kl KeyboardLayout) ShiftKeyDefinition(key KeyInput) KeyDefinition {
+	for _, d := range kl.Keys {
 		if d.ShiftKey == string(key) {
-			return k, d
+			return d
 		}
 	}
-	return key, KeyDefinition{}
+	return KeyDefinition{}
 }
 
 //nolint:gochecknoglobals