Apply review requests (#608)

Co-authored-by: Ankur <ankur.agarwal@grafana.com>
Co-authored-by: Ivan Mirić <ivan.miric@grafana.com>

Author: 3 people

common/launch.go renamed to common/browser_options.go

@@ -10,6 +10,7 @@ import (
 	"github.com/grafana/xk6-browser/k6ext"
 )
 
+// ProxyOptions allows configuring a proxy server.
 type ProxyOptions struct {
 	Server   string
 	Bypass   string
@@ -38,6 +39,7 @@ type LaunchPersistentContextOptions struct {
 	BrowserContextOptions
 }
 
+// NewLaunchOptions returns a new LaunchOptions.
 func NewLaunchOptions() *LaunchOptions {
 	launchOpts := LaunchOptions{
 		Env:               make(map[string]string),

common/launch_test.go renamed to common/browser_options_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/grafana/xk6-browser/k6ext/k6test"
 )
 
-func TestLaunchOptionsParse(t *testing.T) {
+func TestBrowserLaunchOptionsParse(t *testing.T) {
 	t.Parallel()
 
 	for name, tt := range map[string]struct {
@@ -56,7 +56,7 @@ func TestLaunchOptionsParse(t *testing.T) {
 			},
 		},
 		"debug_err": {
-			opts: map[string]any{"debug": "hello"},
+			opts: map[string]any{"debug": "true"},
 			err:  "debug should be a boolean",
 		},
 		"devtools": {
@@ -69,7 +69,7 @@ func TestLaunchOptionsParse(t *testing.T) {
 			},
 		},
 		"devtools_err": {
-			opts: map[string]any{"devtools": "hello"},
+			opts: map[string]any{"devtools": "true"},
 			err:  "devtools should be a boolean",
 		},
 		"env": {
@@ -108,7 +108,7 @@ func TestLaunchOptionsParse(t *testing.T) {
 			},
 		},
 		"headless_err": {
-			opts: map[string]any{"headless": "ABC"},
+			opts: map[string]any{"headless": "true"},
 			err:  "headless should be a boolean",
 		},
 		"ignoreDefaultArgs": {
@@ -196,7 +196,8 @@ func TestLaunchOptionsParse(t *testing.T) {
 				vu = k6test.NewVU(t)
 				lo = NewLaunchOptions()
 			)
-			if err := lo.Parse(vu.Context(), vu.ToGojaValue(tt.opts)); tt.err != "" {
+			err := lo.Parse(vu.Context(), vu.ToGojaValue(tt.opts))
+			if tt.err != "" {
 				require.ErrorContains(t, err, tt.err)
 			} else {
 				require.NoError(t, err)

common/options.go

@@ -3,17 +3,19 @@ package common
 import (
 	"fmt"
 	"reflect"
-	"strconv"
 	"time"
 
 	"github.com/dop251/goja"
+
+	"go.k6.io/k6/lib/types"
 )
 
 func parseBoolOpt(key string, val goja.Value) (b bool, err error) {
-	if b, err = strconv.ParseBool(val.String()); err != nil {
-		return false, fmt.Errorf("%s should be a boolean: %w", key, err)
+	if val.ExportType().Kind() != reflect.Bool {
+		return false, fmt.Errorf("%s should be a boolean", key)
 	}
-	return
+	b, _ = val.Export().(bool)
+	return b, nil
 }
 
 func parseStrOpt(key string, val goja.Value) (s string, err error) {
@@ -24,7 +26,7 @@ func parseStrOpt(key string, val goja.Value) (s string, err error) {
 }
 
 func parseTimeOpt(key string, val goja.Value) (t time.Duration, err error) {
-	if t, err = time.ParseDuration(val.String()); err != nil {
+	if t, err = types.GetDurationValue(val.String()); err != nil {
 		return time.Duration(0), fmt.Errorf("%s should be a time duration value: %w", key, err)
 	}
 	return
@@ -45,7 +47,7 @@ func exportOpt[T any](rt *goja.Runtime, key string, src goja.Value, dst T) error
 		reflect.Slice:  "an array of",
 	}[kind]
 	if !ok {
-		panic("src should be one of: map, struct, slice")
+		panic("dst should be one of: map, struct, slice")
 	}
 	if err := rt.ExportTo(src, dst); err != nil {
 		if kind == reflect.Slice {