Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Commit 21cc7b9

Browse files
committed
Optimize keyDefinitionFromKey
This makes the function less readable and clear, but it's ok for here.
1 parent 4cfc9f6 commit 21cc7b9

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

common/keyboard.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,21 +184,21 @@ func (k *Keyboard) keyDefinitionFromKey(keyString keyboardlayout.KeyInput) keybo
184184
// Find based on key value instead of code
185185
if !ok {
186186
for key, def := range layout.Keys {
187-
if def.Key != string(keyString) {
188-
continue
187+
if def.Key == string(keyString) {
188+
keyString, srcKeyDef = key, def
189+
ok = true // don't look for a shift key below
190+
break
189191
}
190-
keyString, srcKeyDef = key, def
191-
ok = true // don't look for a shift key below
192192
}
193193
}
194194
// try to find with the shift key value
195195
shift := k.modifiers & ModifierKeyShift
196196
if !ok {
197197
for key, def := range layout.Keys {
198-
if def.ShiftKey != string(keyString) {
199-
continue
198+
if def.ShiftKey == string(keyString) {
199+
keyString, srcKeyDef = key, def
200+
break
200201
}
201-
keyString, srcKeyDef = key, def
202202
}
203203
shift = k.modifiers | ModifierKeyShift
204204
}

0 commit comments

Comments
 (0)