Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Commit 0654e7a

Browse files
committed
Remove logging in-flight requests
We noticed that we shouldn't find an internally failed request as it can cause data race issues within the internal components of the module. Also, we've decided that logging in-flight requests only adds noise without bringing any tangingle value. We keep logging the failed request, though. ...
1 parent 83d3942 commit 0654e7a

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

common/frame_manager.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -447,24 +447,6 @@ func (m *FrameManager) requestFailed(req *Request, canceled bool) {
447447
}
448448
frame.deleteRequest(req.getID())
449449

450-
ifr := frame.cloneInflightRequests()
451-
switch rc := len(ifr); {
452-
case rc <= 10:
453-
for reqID := range ifr {
454-
req, ok := frame.requestByID(reqID)
455-
if !ok {
456-
m.logger.Debugf("FrameManager:requestFailed:rc<=10 request is nil",
457-
"reqID:%s frameID:%s",
458-
reqID, frame.ID())
459-
continue
460-
}
461-
462-
m.logger.Debugf("FrameManager:requestFailed:rc<=10",
463-
"reqID:%s inflightURL:%s frameID:%s",
464-
reqID, req.URL(), frame.ID())
465-
}
466-
}
467-
468450
frame.pendingDocumentMu.RLock()
469451
if frame.pendingDocument == nil || frame.pendingDocument.request != req {
470452
m.logger.Debugf("FrameManager:requestFailed:return", "fmid:%d pdoc:nil", m.ID())

0 commit comments

Comments
 (0)