Skip to content

Commit 796f4d7

Browse files
authored
Fix metrics TLS certificate parameters (#1128)
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
1 parent 7846041 commit 796f4d7

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

bundle/community/manifests/tempo-operator.clusterserviceversion.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ metadata:
7474
capabilities: Deep Insights
7575
categories: Logging & Tracing,Monitoring
7676
containerImage: ghcr.io/grafana/tempo-operator/tempo-operator:v0.15.1
77-
createdAt: "2025-02-17T13:21:50Z"
77+
createdAt: "2025-02-20T06:15:35Z"
7878
description: Create and manage deployments of Tempo, a high-scale distributed
7979
tracing backend.
8080
operatorframework.io/cluster-monitoring: "true"

bundle/openshift/manifests/tempo-operator.clusterserviceversion.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ metadata:
7474
capabilities: Deep Insights
7575
categories: Logging & Tracing,Monitoring
7676
containerImage: ghcr.io/grafana/tempo-operator/tempo-operator:v0.15.1
77-
createdAt: "2025-02-17T13:21:48Z"
77+
createdAt: "2025-02-20T06:15:33Z"
7878
description: Create and manage deployments of Tempo, a high-scale distributed
7979
tracing backend.
8080
operatorframework.io/cluster-monitoring: "true"
@@ -1516,8 +1516,7 @@ spec:
15161516
- --zap-log-level=info
15171517
- start
15181518
- --config=controller_manager_config.yaml
1519-
- --metrics-tls-private-key-file=/var/run/tls/server/tls.key
1520-
- --metrics-tls-cert-file=/var/run/tls/server/tls.crt
1519+
- --metrics-tls-cert-dir=/var/run/tls/server/
15211520
env:
15221521
- name: RELATED_IMAGE_TEMPO
15231522
value: docker.io/grafana/tempo:2.7.1

cmd/start/main.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,13 @@ func start(c *cobra.Command, args []string) {
3232
version := version.Get()
3333

3434
options.PprofBindAddress, _ = c.Flags().GetString("pprof-addr")
35-
options.Metrics.CertName, _ = c.Flags().GetString("metrics-tls-cert-file")
36-
options.Metrics.KeyName, _ = c.Flags().GetString("metrics-tls-private-key-file")
35+
36+
certDir, _ := c.Flags().GetString("metrics-tls-cert-dir")
37+
if certDir != "" {
38+
options.Metrics.CertDir = certDir
39+
options.Metrics.CertName, _ = c.Flags().GetString("metrics-tls-cert-file")
40+
options.Metrics.KeyName, _ = c.Flags().GetString("metrics-tls-private-key-file")
41+
}
3742

3843
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), options)
3944
if err != nil {
@@ -162,7 +167,8 @@ func NewStartCommand() *cobra.Command {
162167
Run: start,
163168
}
164169
cmd.Flags().String("pprof-addr", "", "The address the pprof server binds to. Default is empty string which disables the pprof server.")
165-
cmd.Flags().String("metrics-tls-cert-file", "", "TLS certificate used by metrics server")
166-
cmd.Flags().String("metrics-tls-private-key-file", "", "TLS key used by metrics server")
170+
cmd.Flags().String("metrics-tls-cert-dir", "", "TLS certificate used by metrics server")
171+
cmd.Flags().String("metrics-tls-cert-file", "tls.crt", "TLS certificate used by metrics server")
172+
cmd.Flags().String("metrics-tls-private-key-file", "tls.key", "TLS key used by metrics server")
167173
return cmd
168174
}

config/overlays/openshift/patch_tls_metrics_args.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
- op: add
22
path: /spec/template/spec/containers/0/args/-
3-
value: --metrics-tls-private-key-file=/var/run/tls/server/tls.key
4-
5-
- op: add
6-
path: /spec/template/spec/containers/0/args/-
7-
value: --metrics-tls-cert-file=/var/run/tls/server/tls.crt
3+
value: --metrics-tls-cert-dir=/var/run/tls/server/
84

95
- op: add
106
path: /spec/template/spec/volumes/-

0 commit comments

Comments
 (0)