Skip to content

Database connections are not closed when a new datasource is created #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
njvrzm opened this issue Sep 30, 2024 · 0 comments · Fixed by #136
Closed

Database connections are not closed when a new datasource is created #135

njvrzm opened this issue Sep 30, 2024 · 0 comments · Fixed by #136
Assignees
@njvrzm
Labels
bug Something isn't working effort/small

Comments

@njvrzm
Copy link
Contributor

njvrzm commented Sep 30, 2024 •
edited
Loading

grafana-plugin-sdk-go supports a Dispose() method to be called when a new Instance is to be created. Sqlds does not currently support this. This leaks database connections in some circumstances.

SQLDatasource should support the InstanceDisposer interface and have its Connector close its open database connections when Dispose() is called. I'm working on a PR for this now.
@njvrzm njvrzm added the bug Something isn't working label Sep 30, 2024
@njvrzm njvrzm self-assigned this Sep 30, 2024
@njvrzm njvrzm mentioned this issue Sep 30, 2024
Merged
@iwysiu iwysiu moved this from Incoming to In Progress in AWS Datasources Sep 30, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in AWS Datasources Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njvrzm njvrzm

Labels
bug Something isn't working effort/small
Projects
AWS Datasources
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: implement InstanceDisposer to close db connections grafana/sqlds
1 participant
@njvrzm