Skip to content

Commit 03099c4

Browse files
committed
Correct test grouping
1 parent be86a51 commit 03099c4

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

macros_test.go

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,11 @@ func TestInterpolate(t *testing.T) {
8080
}
8181
}
8282

83-
func TestGetMacroRegex(t *testing.T) {
84-
t.Run("returns composed regular expression", func(t *testing.T) {
85-
assert.Equal(t, `\$__some_string\b(?:\((.*?)\))?`, getMacroRegex("some_string"))
86-
})
83+
func TestGetMacroRegex_returns_composed_regular_expression(t *testing.T) {
84+
assert.Equal(t, `\$__some_string\b(?:\((.*?)\))?`, getMacroRegex("some_string"))
85+
}
86+
87+
func TestGetMatches(t *testing.T) {
8788
t.Run("FindAllStringSubmatch returns DefaultMacros", func(t *testing.T) {
8889
for macroName := range DefaultMacros {
8990
matches, err := getMatches(macroName, fmt.Sprintf("$__%s", macroName))
@@ -92,15 +93,10 @@ func TestGetMacroRegex(t *testing.T) {
9293
assert.Equal(t, [][]string{{fmt.Sprintf("$__%s", macroName), ""}}, matches)
9394
}
9495
})
95-
}
96+
t.Run("does not return matches for macro name which is substring", func(t *testing.T) {
97+
matches, err := getMatches("timeFilter", "$__timeFilterEpoch(time_column)")
9698

97-
func TestGetMacroRegex_returns_composed_regular_expression(t *testing.T) {
98-
assert.Equal(t, `\$__some_string\b(?:\((.*?)\))?`, getMacroRegex("some_string"))
99-
}
100-
101-
func TestGetMatches_does_not_match_for_macro_name_which_is_substring(t *testing.T) {
102-
matches, err := getMatches("timeFilter", "$__timeFilterEpoch(time_column)")
103-
104-
assert.NoError(t, err)
105-
assert.Nil(t, matches)
99+
assert.NoError(t, err)
100+
assert.Nil(t, matches)
101+
})
106102
}

0 commit comments

Comments
 (0)