-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Open
Description
What
- Move Sobek option parsing to the mapping layer.
Why
- Separation of concerns.
- Option parsing is only required by the mapping layer.
- To simplify and make the code and tests easy to reason about.
Current options to move
- Move
ConvertSelectOptionValuesfrombrowsertocommon#5302 -
ElementHandleBaseOptions -
Frameoptions -
Locatoroptions -
Mouseoptions -
Size.Parse -
PageEmulateMediaOptions -
PageReloadOptions -
PageScreenshotOptions
Example
- In this code, the parsing happens in the mapping layer.
Related
- This issue is a continuation of the epic issue Move Sobek entirely out of the business logic #4219.