golanci-lint: drop unused nolint and some other fixes around that

Author: mstoykov

errext/exitcodes/codes.go

@@ -1,6 +1,4 @@
 // Package exitcodes contains the constants representing possible k6 exit error codes.
-//
-//nolint:golint
 package exitcodes
 
 // ExitCode is just a type representing a process exit code for k6

internal/cmd/cloud.go

@@ -118,7 +118,7 @@ func (c *cmdCloud) run(cmd *cobra.Command, args []string) error {
 		return err
 	}
 	if !cloudConfig.Token.Valid {
-		return errors.New( //nolint:golint
+		return errors.New(
 			"not logged in, please login first to the Grafana Cloud k6 " +
 				"using the \"k6 cloud login\" command",
 		)
@@ -313,7 +313,6 @@ func (c *cmdCloud) run(cmd *cobra.Command, args []string) error {
 		logger.WithField("run_status", testProgress.RunStatusText).Debug("Test finished")
 	}
 
-	//nolint:stylecheck,golint
 	if testProgress.ResultStatus == cloudapi.ResultStatusFailed {
 		// Although by looking at [ResultStatus] and [RunStatus] isn't self-explanatory,
 		// the scenario when the test run has finished, but it failed is an exceptional case for those situations

internal/js/eventloop/eventloop.go

@@ -193,7 +193,7 @@ func (e *EventLoop) Start(firstCallback func() error) error {
 				}
 			}
 			// this is the de facto wording in both firefox and deno at least
-			return fmt.Errorf("Uncaught (in promise) %s", value) //nolint:stylecheck,staticcheck
+			return fmt.Errorf("Uncaught (in promise) %s", value) //nolint:staticcheck
 		}
 	}
 }

internal/js/modules/k6/experimental/streams/readable_stream_default_controller.go

@@ -220,7 +220,7 @@ func (controller *ReadableStreamDefaultController) pullSteps(readRequest ReadReq
 // [specification]: https://streams.spec.whatwg.org/#abstract-opdef-readablestreamdefaultcontroller-releasesteps
 func (controller *ReadableStreamDefaultController) releaseSteps() {
 	// 1.
-	return //nolint:gosimple,staticcheck
+	return //nolint:staticcheck
 }
 
 // close implements the [ReadableStreamDefaultControllerClose] algorithm

internal/js/modules/k6/grpc/client.go

@@ -155,7 +155,7 @@ func buildTLSConfig(parentConfig *tls.Config, certificate, key []byte, caCertifi
 	// Ignoring 'TLS MinVersion is too low' because this tls.Config will inherit MinValue and MaxValue
 	// from the vu state tls.Config
 
-	//nolint:golint,gosec
+	//nolint:gosec
 	tlsCfg := &tls.Config{
 		CipherSuites:       parentConfig.CipherSuites,
 		InsecureSkipVerify: parentConfig.InsecureSkipVerify,

internal/js/modules/k6/webcrypto/jwk.go

@@ -20,7 +20,7 @@ const (
 )
 
 // JsonWebKey represents a JSON Web Key (JsonWebKey) key.
-type JsonWebKey map[string]interface{} //nolint:stylecheck,revive // we name this type JsonWebKey to match the spec
+type JsonWebKey map[string]interface{} //nolint:revive // we name this type JsonWebKey to match the spec
 
 // Set sets a key-value pair in the JWK.
 func (jwk *JsonWebKey) Set(key string, value interface{}) {

internal/js/tc39/tc39_test.go

@@ -257,7 +257,7 @@ var (
 	update = flag.Bool("update", false, "update breaking_test_errors-*.json files") //nolint:gochecknoglobals
 )
 
-//nolint:unused,structcheck
+//nolint:unused
 type tc39Test struct {
 	name string
 	f    func(t *testing.T)
@@ -278,7 +278,7 @@ type tc39TestCtx struct {
 	enableBench    bool
 	benchmark      tc39BenchmarkData
 	benchLock      sync.Mutex
-	testQueue      []tc39Test //nolint:unused,structcheck
+	testQueue      []tc39Test //nolint:unused
 	expectedErrors map[string]string
 
 	errorsLock sync.Mutex
@@ -419,7 +419,7 @@ func (ctx *tc39TestCtx) runTC39Test(t testing.TB, name, src string, meta *tc39Me
 	}
 
 	var out []string
-	async := meta.hasFlag("async") //nolint:ifshort // false positive
+	async := meta.hasFlag("async")
 	if async {
 		err = ctx.runFile(ctx.base, path.Join("harness", "doneprintHandle.js"), vm)
 		if err != nil {

internal/lib/netext/grpcext/conn.go

@@ -240,7 +240,7 @@ func (statsHandler) TagRPC(ctx context.Context, _ *grpcstats.RPCTagInfo) context
 // HandleRPC implements the grpcstats.Handler interface
 func (h statsHandler) HandleRPC(ctx context.Context, stat grpcstats.RPCStats) {
 	state := h.getState()
-	stateRPC := getRPCState(ctx) //nolint:ifshort
+	stateRPC := getRPCState(ctx)
 
 	// If the request is done by the reflection handler then the tags will be
 	// nil. In this case, we can reuse the VU.State's Tags.

internal/lib/testutils/httpmultibin/grpc_wrappers_testing/service.go

@@ -1,5 +1,5 @@
 // Package grpc_wrappers_testing provides a test service that could be used for the testing gRPC wrappers
-package grpc_wrappers_testing //nolint:revive,stylecheck // we want to be consistent with the other packages
+package grpc_wrappers_testing //nolint:revive // we want to be consistent with the other packages
 
 import (
 	context "context"

js/common/bridge_test.go

@@ -12,8 +12,8 @@ type bridgeTestFieldsType struct {
 	Exported       string
 	ExportedTag    string `js:"renamed"`
 	ExportedHidden string `js:"-"`
-	unexported     string //nolint:structcheck,unused // actually checked in the test
-	unexportedTag  string `js:"unexported"` //nolint:structcheck,unused // actually checked in the test
+	unexported     string //nolint:unused // actually checked in the test
+	unexportedTag  string `js:"unexported"` //nolint:unused // actually checked in the test
 }
 
 type bridgeTestMethodsType struct{}