golanci-lint: fixes for paralleltest

Author: mstoykov

api/v1/metric_routes_test.go

@@ -120,6 +120,8 @@ func TestGetMetric(t *testing.T) {
 		})
 
 		t.Run("metric", func(t *testing.T) {
+			t.Parallel()
+
 			var envelop metricJSONAPI
 
 			assert.NoError(t, json.Unmarshal(rw.Body.Bytes(), &envelop))

internal/js/bundle_test.go

@@ -760,7 +760,7 @@ func TestOpen(t *testing.T) {
 
 					for source, b := range map[string]*Bundle{"source": sourceBundle, "archive": arcBundle} {
 						b := b
-						t.Run(source, func(t *testing.T) {
+						t.Run(source, func(t *testing.T) { //nolint:paralleltest
 							bi, err := b.Instantiate(context.Background(), 0)
 							require.NoError(t, err)
 							v, err := bi.getCallableExport(consts.DefaultFn)(sobek.Undefined())
@@ -770,13 +770,13 @@ func TestOpen(t *testing.T) {
 					}
 				}
 
-				t.Run(tCase.name, testFunc)
+				t.Run(tCase.name, testFunc) //nolint:paralleltest
 				if isWindows {
 					tCase := tCase // copy test case before making modifications
 					// windowsify the testcase
 					tCase.openPath = strings.ReplaceAll(tCase.openPath, `/`, `\`)
 					tCase.pwd = strings.ReplaceAll(tCase.pwd, `/`, `\`)
-					t.Run(tCase.name+" with windows slash", testFunc)
+					t.Run(tCase.name+" with windows slash", testFunc) //nolint:paralleltest
 				}
 			}
 		})

internal/js/modules/k6/crypto/crypto_test.go

@@ -509,7 +509,7 @@ func TestHexEncode(t *testing.T) {
 
 		for _, tc := range testCases {
 			tc := tc
-			t.Run(fmt.Sprintf("%T", tc), func(t *testing.T) {
+			t.Run(fmt.Sprintf("%T", tc), func(t *testing.T) { //nolint:paralleltest
 				c := Crypto{}
 				out, err := c.hexEncode(tc)
 				require.NoError(t, err)

internal/js/modules/k6/metrics/metrics_test.go

@@ -129,7 +129,7 @@ func TestMetrics(t *testing.T) {
 					_, err := test.rt.RunString(fmt.Sprintf(`var m = new metrics.%s("my_metric"%s)`, fn, isTimeString))
 					require.NoError(t, err)
 
-					t.Run("ExitInit", func(t *testing.T) {
+					t.Run("ExitInit", func(t *testing.T) { //nolint:paralleltest
 						mii.StateField = state
 						mii.InitEnvField = nil
 						_, err := test.rt.RunString(fmt.Sprintf(`new metrics.%s("my_metric")`, fn))
@@ -147,13 +147,13 @@ func TestMetrics(t *testing.T) {
 						for _, isThrow := range []bool{false, true} {
 							state.Options.Throw.Bool = isThrow
 							test.isThrow = isThrow
-							t.Run(fmt.Sprintf("%s/isThrow=%v/Simple", name, isThrow), func(t *testing.T) {
+							t.Run(fmt.Sprintf("%s/isThrow=%v/Simple", name, isThrow), func(t *testing.T) { //nolint:paralleltest
 								test.js = fmt.Sprintf(`m.add(%v)`, val.JS)
 								test.expectedTags = map[string]string{"key": "value"}
 								test.run(t)
 							})
 							if !val.noTags {
-								t.Run(fmt.Sprintf("%s/isThrow=%v/Tags", name, isThrow), func(t *testing.T) {
+								t.Run(fmt.Sprintf("%s/isThrow=%v/Tags", name, isThrow), func(t *testing.T) { //nolint:paralleltest
 									test.js = fmt.Sprintf(`m.add(%v, {a:1})`, val.JS)
 									test.expectedTags = map[string]string{"key": "value", "a": "1"}
 									test.run(t)

internal/js/runner_test.go

@@ -74,7 +74,7 @@ func TestRunnerNew(t *testing.T) {
 			assert.Equal(t, int64(0), vuc.getExported("counter").Export())
 
 			vu := initVU.Activate(&lib.VUActivationParams{RunContext: ctx})
-			t.Run("RunOnce", func(t *testing.T) {
+			t.Run("RunOnce", func(t *testing.T) { //nolint:paralleltest
 				err = vu.RunOnce()
 				require.NoError(t, err)
 				assert.Equal(t, int64(1), vuc.getExported("counter").Export())
@@ -535,7 +535,9 @@ func TestRunnerIntegrationImports(t *testing.T) {
 		for _, mod := range modules {
 			mod := mod
 			t.Run(mod, func(t *testing.T) {
+				t.Parallel()
 				t.Run("Source", func(t *testing.T) {
+					t.Parallel()
 					_, err := getSimpleRunner(t, "/script.js",
 						fmt.Sprintf(`import "%s"; export default function() {}`, mod), rtOpts)
 					require.NoError(t, err)
@@ -575,6 +577,7 @@ func TestRunnerIntegrationImports(t *testing.T) {
 				for name, r := range testdata {
 					r := r
 					t.Run(name, func(t *testing.T) {
+						t.Parallel()
 						ctx, cancel := context.WithCancel(context.Background())
 						defer cancel()
 						initVU, err := r.NewVU(ctx, 1, 1, make(chan metrics.SampleContainer, 100))

internal/loader/loader_test.go

@@ -251,10 +251,11 @@ func TestLoad(t *testing.T) {
 			{"HOST", "https://some-path-that-doesnt-exist.js"},
 		}
 
-		filesystems := map[string]fsext.Fs{"https": fsext.NewMemMapFs()}
 		for _, data := range testData {
 			moduleSpecifier := data.moduleSpecifier
 			t.Run(data.name, func(t *testing.T) {
+				filesystems := map[string]fsext.Fs{"https": fsext.NewMemMapFs()}
+				t.Parallel()
 				moduleSpecifierURL, err := loader.Resolve(root, moduleSpecifier)
 				require.NoError(t, err)
 

lib/options_test.go

@@ -372,6 +372,7 @@ func TestOptions(t *testing.T) {
 		}
 		for _, tc := range tests {
 			t.Run(tc.name, func(t *testing.T) {
+				t.Parallel()
 				tlsAuth := []*TLSAuth{
 					{TLSAuthFields{
 						Domains:  domains,
@@ -384,6 +385,7 @@ func TestOptions(t *testing.T) {
 				assert.Equal(t, tlsAuth, opts.TLSAuth)
 
 				t.Run("Roundtrip", func(t *testing.T) {
+					t.Parallel()
 					optsData, err := json.Marshal(opts)
 					assert.NoError(t, err)
 

metrics/thresholds_test.go

@@ -192,7 +192,7 @@ func TestThresholdRun(t *testing.T) {
 		threshold := newThreshold(`rate<0.01`, false, types.NullDuration{})
 		threshold.parsed = parsed
 
-		t.Run("no taint", func(t *testing.T) {
+		t.Run("no taint", func(t *testing.T) { //nolint:paralleltest
 			b, err := threshold.runNoTaint(sinks)
 			assert.NoError(t, err)
 			assert.True(t, b)
@@ -218,14 +218,14 @@ func TestThresholdRun(t *testing.T) {
 		threshold := newThreshold(`rate<0.01`, false, types.NullDuration{})
 		threshold.parsed = parsed
 
-		t.Run("no taint", func(t *testing.T) {
+		t.Run("no taint", func(t *testing.T) { //nolint:paralleltest
 			b, err := threshold.runNoTaint(sinks)
 			assert.NoError(t, err)
 			assert.False(t, b)
 			assert.False(t, threshold.LastFailed)
 		})
 
-		t.Run("taint", func(t *testing.T) {
+		t.Run("taint", func(t *testing.T) { //nolint:paralleltest
 			b, err := threshold.run(sinks)
 			assert.NoError(t, err)
 			assert.False(t, b)
@@ -839,7 +839,7 @@ func TestThresholdsJSON(t *testing.T) {
 				assert.Equal(t, data.gracePeriod, ts.Thresholds[i].AbortGracePeriod)
 			}
 
-			t.Run("marshal", func(t *testing.T) {
+			t.Run("marshal", func(t *testing.T) { //nolint:paralleltest
 				data2, err := MarshalJSONWithoutHTMLEscape(ts)
 				assert.NoError(t, err)
 				output := data.JSON