secretsource: do not panic on unknown values but redact them wiht a message

mstoykov · mstoykov · commit 6737abdd770b · 2025-03-13T16:07:30.000+02:00
diff --git a/secretsource/hook.go b/secretsource/hook.go
@@ -64,6 +64,6 @@ func recursiveReplace(v any, replacer *strings.Replacer) any {
 	case time.Duration:
 		return v
 	}
-	// replace this with a log after more testing
-	panic(fmt.Sprintf("Had a logrus.fields value with type %T, please report that this is unsupported", v))
+	return fmt.Sprintf("Had a logrus.fields value with type %T, "+
+		"please report that this is unsupported and will be redacted in all logs in case it containing secrets", v)
 }

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,6 @@ func recursiveReplace(v any, replacer *strings.Replacer) any {`
`64`	`64`	`case time.Duration:`
`65`	`65`	`return v`
`66`	`66`	`}`
`67`		`- // replace this with a log after more testing`
`68`		`- panic(fmt.Sprintf("Had a logrus.fields value with type %T, please report that this is unsupported", v))`
	`67`	`+ return fmt.Sprintf("Had a logrus.fields value with type %T, "+`
	`68`	`+ "please report that this is unsupported and will be redacted in all logs in case it containing secrets", v)`
`69`	`69`	`}`