Skip to content

Commit 7b25087

Browse files
committed
Improve experimental settings
1 parent 1af4e8b commit 7b25087

File tree

3 files changed

+22
-17
lines changed

3 files changed

+22
-17
lines changed

src/components/ExperimentalEditor.tsx

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,39 +13,43 @@ interface Props {
1313

1414
export const ExperimentalEditor = ({ query, onChange, onRunQuery, editorContext }: Props) => {
1515
// Group by
16-
const { groupByField } = query;
16+
const { experimentalGroupByField: groupByField } = query;
1717

1818
const onGroupByChange = (field?: string) => {
19-
onChange({ ...query, groupByField: field });
19+
onChange({ ...query, experimentalGroupByField: field });
2020
onRunQuery();
2121
};
2222

2323
// Metric
24-
const { metricField } = query;
24+
const { experimentalMetricField: metricField } = query;
2525

2626
const onMetricChange = (field?: string) => {
27-
onChange({ ...query, metricField: field });
27+
onChange({ ...query, experimentalMetricField: field });
2828
onRunQuery();
2929
};
3030

3131
// Variable label
32-
const { variableTextField } = query;
32+
const { experimentalVariableTextField: variableTextField } = query;
3333

3434
const onVariableLabelChange = (field?: string) => {
35-
onChange({ ...query, variableTextField: field });
35+
onChange({ ...query, experimentalVariableTextField: field });
3636
onRunQuery();
3737
};
3838

3939
// Variable value
40-
const { variableValueField } = query;
40+
const { experimentalVariableValueField: variableValueField } = query;
4141

4242
const onVariableValueChange = (field?: string) => {
43-
onChange({ ...query, variableValueField: field });
43+
onChange({ ...query, experimentalVariableValueField: field });
4444
onRunQuery();
4545
};
4646

4747
const fieldNames = query.fields
4848
.map((field) => {
49+
if (field.name) {
50+
return field.name;
51+
}
52+
4953
const pathArray = (JSONPath as any).toPathArray(field.jsonPath);
5054
return pathArray[pathArray.length - 1];
5155
})

src/datasource.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,9 @@ export class JsonDataSource extends DataSourceApi<JsonApiQuery, JsonApiDataSourc
6565
return [];
6666
}
6767

68-
const labelField = frame.fields.find((field) => field.name === query.variableTextField) ?? frame.fields[0];
69-
const valueField = frame.fields.find((field) => field.name === query.variableValueField) ?? labelField;
68+
const labelField =
69+
frame.fields.find((field) => field.name === query.experimentalVariableTextField) ?? frame.fields[0];
70+
const valueField = frame.fields.find((field) => field.name === query.experimentalVariableValueField) ?? labelField;
7071

7172
return Array.from({ length: frame.length }).map((_, idx) => ({
7273
text: labelField.values.get(idx),
@@ -159,14 +160,14 @@ export class JsonDataSource extends DataSourceApi<JsonApiQuery, JsonApiDataSourc
159160
throw new Error('Fields have different lengths');
160161
}
161162

162-
const frames = query.groupByField
163+
const frames = query.experimentalGroupByField
163164
? groupBy(
164165
toDataFrame({
165166
name: query.refId,
166167
refId: query.refId,
167168
fields: fields,
168169
}),
169-
query.groupByField
170+
query.experimentalGroupByField
170171
)
171172
: [
172173
toDataFrame({
@@ -180,7 +181,7 @@ export class JsonDataSource extends DataSourceApi<JsonApiQuery, JsonApiDataSourc
180181
...frame,
181182
fields: fields.map(
182183
(field: Field): Field =>
183-
field.name === query.metricField ? { ...field, config: { displayNameFromDS: frame.name } } : field
184+
field.name === query.experimentalMetricField ? { ...field, config: { displayNameFromDS: frame.name } } : field
184185
),
185186
}));
186187

src/types.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ export interface JsonApiQuery extends DataQuery {
2222
jsonPath?: string;
2323

2424
// Experimental
25-
groupByField?: string;
26-
metricField?: string;
27-
variableTextField?: string;
28-
variableValueField?: string;
25+
experimentalGroupByField?: string;
26+
experimentalMetricField?: string;
27+
experimentalVariableTextField?: string;
28+
experimentalVariableValueField?: string;
2929
}
3030

3131
export const defaultQuery: Partial<JsonApiQuery> = {

0 commit comments

Comments
 (0)